emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: `help-with-tutorial' (with arg) completion problem


From: Basil L. Contovounesios
Subject: Re: `help-with-tutorial' (with arg) completion problem
Date: Fri, 14 Dec 2018 15:39:46 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

John Paul Wallington <address@hidden> writes:

> Doing C-u C-h t or picking Help => Emacs Tutorial (choose language)
> from the menu gives the completion list right away.

Why does help-with-tutorial, when invoked with a prefix argument,
preemptively pop up the *Completions* buffer?  This seems to diverge
from most uses of completing-read I've seen, which defer popping up the
*Completions* buffer until the user invokes minibuffer-complete or
similar.  What's more, I noticed this behaviour due to a custom
completing-read-function I use which forgoes using the *Completions*
buffer, so I find the current default a little intrusive.

If it is not crucial for the *Completions* buffer to be displayed
immediately, could this minibuffer setup be removed?

diff --git a/lisp/tutorial.el b/lisp/tutorial.el
index e3fbdf019c..3e9f5ed35b 100644
--- a/lisp/tutorial.el
+++ b/lisp/tutorial.el
@@ -764,8 +764,7 @@ help-with-tutorial
          (message prompt1)))
     (let* ((lang (cond
                   (arg
-                   (minibuffer-with-setup-hook #'minibuffer-completion-help
-                     (read-language-name 'tutorial "Language: " "English")))
+                   (read-language-name 'tutorial "Language: " "English"))
                   ((get-language-info current-language-environment 'tutorial)
                    current-language-environment)
                   (t "English")))
Thanks,

-- 
Basil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]