emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: harfbuzz 2f72162: Fix crash in the Cairo build


From: Eli Zaretskii
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Wed, 19 Dec 2018 17:06:45 +0200

> From: Robert Pluim <address@hidden>
> Date: Wed, 19 Dec 2018 09:32:52 +0100
> 
> >> On 12/17/18 4:41 AM, Robert Pluim wrote:
> >>> +#ifdef HAVE_XFT
> >>> +#include <X11/Xlib.h>
> >>> +#include <X11/Xft/Xft.h>
> >>> +#endif
> >>> +#ifdef USE_CAIRO
> >>> +#include <cairo-ft.h>
> >>> +#endif
> >>
> >> Please indent the include directives by using "# include" (with a
> >> space after "#").
> >
> > Fixed.
> 
> BTW, Emacs has ~500 instances of this rule not being followed. Iʼm
> assuming that a mass change (similarly to mass whitespace fixes) would
> be frowned upon.

We usually fix those as part of other changes, not as a changeset in
itself.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]