Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c

[Daniel Colascione]

>> branch: master
>> commit 8e2b2a2b179c3ed170ad9de32a320e788c6a3a5e
>> Author: Eli Zaretskii <address@hidden>
>> Commit: Eli Zaretskii <address@hidden>
>>
>>     Minor cleanup in pdumper.c
>>
>>     * src/pdumper (subtract_timespec): Function removed.
>>     (pdumper_load): Use timespec_sub instead of subtract_timespec.
>> ---
>>  src/pdumper.c | 16 +++++-----------
>>  1 file changed, 5 insertions(+), 11 deletions(-)
>>
>> diff --git a/src/pdumper.c b/src/pdumper.c
>> index b51a379..1c49167 100644
>> --- a/src/pdumper.c
>> +++ b/src/pdumper.c
>> @@ -5388,15 +5388,6 @@ enum dump_section
>>     NUMBER_DUMP_SECTIONS,
>>    };
>>
>> -/* Subtract two timespecs, yielding a difference in milliseconds. */
>> -static double
>> -subtract_timespec (struct timespec minuend, struct timespec subtrahend)
>
> Cmon, don't you think we should do better than open-code timespec
> operations?

Ah, never mind. I saw the constants at the end of the patch and jumped the
gun.