Re: master 57d2f24: * lisp/frame.el (make-frame-on-monitor): New command. (Bug#34516)

[Robert Pluim]

Juri Linkov <address@hidden> writes:

>>> Iʼve lost track: did we still want to fake monitor names on recent
>>> versions of macOS where the existing name retrieval methods donʼt work
>>> anymore?
>
> Yes, please add fake monitor names to support this command on macOS too.
>

I can do that. I have a small problem with 'make-frame-on-monitor':
the resulting frame is too tall (itʼs correctly
positioned though). Perhaps toolbars etc need to be
accounted for?

(display-monitor-attributes-list) =>
(((name . "DISPLAY1") (geometry 0 0
1440 900) (workarea 0 23 1440 877) (mm-size 285 179) (frames #<frame
*scratch* 0x7faffa066230>) (source . "NS")))

The frame resulting from 'make-frame-on-monitor' has (frame-geometry) =>
((outer-position 0 . 23) (outer-size 1475 . 868)
(external-border-size 0 . 0) (title-bar-size 0 . 22)
(menu-bar-external) (menu-bar-size 0 . 0) (tool-bar-external . t)
(tool-bar-position . top) (tool-bar-size 1471 . 35)
(internal-border-width . 2))

If I maximize that frame so itʼs the correct height, (frame-geometry)
=>

((outer-position 0 . 23) (outer-size 1475 . 842) (external-border-size 0 . 0) 
(title-bar-size 0 . 22) (menu-bar-external) (menu-bar-size 0 . 0) 
(tool-bar-external . t) (tool-bar-position . top) (tool-bar-size 1471 . 35) 
(internal-border-width . 2))

(Iʼll note that both outer-size and tool-bar-size are wider than the
actual display, so perhaps this is an issue in the macOS code geometry
code).

Robert