[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Increase minimum required GTK versions?

From: Eli Zaretskii
Subject: Re: Increase minimum required GTK versions?
Date: Tue, 09 Apr 2019 21:21:55 +0300

> From: Alex <address@hidden>
> Date: Tue, 09 Apr 2019 11:28:41 -0600
> Cc: Stefan Monnier <address@hidden>, address@hidden
> If there are no objections I'll push the revised patch in a few days.

To allow proper review, please make the log message more detailed.  In
particular, stuff you remove that is not under an explicit GTK version
condition should have a minimal explanation for why it is TRT to
remove it.  (The rationale doesn't have to be in the log message,
although it would be nice to have it there; it could be just in the
email that accompanies the patch.)

Please also tell with which GTK versions did you try building with to
verify the correctness of the changes.

> Subject: [PATCH] Bump minimum GTK versions to 2.24 and 3.10

Not sure we discussed 3.10 as the minimum GTK3 version, we only talked
about 2.x AFAIR.  What is the situation with GTK3 versions in the
current distributions of GNU/Linux?

> -/* True iff GTK's version is at least I.J.K.  */
> -# ifdef USE_GTK
> -#  define GTK_CHECK_VERSION(i, j, k) \
> -     ((i) \
> -      < GTK_MAJOR_VERSION + ((j) \
> -                          < GTK_MINOR_VERSION + ((k) \
> -                                                 <= GTK_MICRO_VERSION)))

Is it really a good idea to remove this macro?  We'll probably have to
reintroduce it right away.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]