[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] Using a display_info union instead of a typedef Display_Info

From: Eli Zaretskii
Subject: Re: [RFC] Using a display_info union instead of a typedef Display_Info
Date: Fri, 12 Apr 2019 20:55:54 +0300

> From: Alex Gramiak <address@hidden>
> Cc: Eli Zaretskii <address@hidden>, Stefan Monnier <address@hidden>
> Date: Fri, 12 Apr 2019 10:50:09 -0600
> The jist of the attached patch is that generalizes x_get_string_resource
> into a terminal hook, and in the process changes several procedures to
> use union display_info instead of the typedef Display_Info, which is
> display system-dependent. One uses DISPLAY_INFO (dpyinfo) to access the
> common structure of the union, and there are macros
> U_DISPLAY_INFO_<suffix> to convert from a specific display_info to the
> union. There is also a procedure gui_frame_display_info, that grabs a
> window system display_info from a frame.
> I've also included a new procedure decode_display_info, which takes the
> role of the display system-dependent check_x_display_info. I've left out
> the removal of the check_x_display_info since I'm not sure if this patch
> will be accepted. I've also left out NS support until a later stage.

Looks to me like replacing one set of window-system specific code with
another: still the same #ifdef's and the same window-system specific
code fragments.  Maybe I'm missing something, but it doesn't look to
me like a change for the better.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]