[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Increase minimum required GTK versions?

From: Eli Zaretskii
Subject: Re: Increase minimum required GTK versions?
Date: Fri, 12 Apr 2019 21:49:54 +0300

> From: Alex <address@hidden>
> Cc: address@hidden,  address@hidden
> Date: Wed, 10 Apr 2019 18:35:12 -0600
> >> * Old file selection dialog
> >> This is only optionally used in GTK 2, but the old dialog is long
> >> deprecated in GTK 2 (removed in GTK 3), so I figured that this is a good
> >> time to remove it and simplify the existing code.
> >
> > I think this should be left alone.  It's a separate issue anyway, and
> > should be submitted separately.  It would be good to try to establish
> > whether this feature is turned on by someone, but given that it's only
> > for GTK2, I tend to think we should simply let it die a natural death
> > together with GTK2.
> Okay, done.

Are you sure?  I still see the code related to this being removed.

> I've attached an updated patch.

Fine with me, modulo the file dialog stuff.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]