Re: Issue with ns_color_defined makeIndex argument

[Alex Gramiak]

Alan Third <address@hidden> writes:

> I’m not familiar with this area of the code, and a review hasn’t done
> anything to enlighten me. This code has been in since the NS port was
> merged, so there’s no explanatory reasoning in commit messages.
>
> If I’m reading the code right, when we lookup a colour in image.c, we
> store a 32bit integer representation of the colour in color_def.pixel,
> but when doing a lookup from xfaces.c, we store an index into a lookup
> table in color_def.pixel.
>
>> If so, does anyone have any ideas to rectify this besides adding an
>> extra argument that non-NS window systems just ignore? I'd rather avoid
>> doing that.
>
> I have no ideas, I’m afraid.

Alright, I just made a wrapper procedure to accommodate NS instead.

Thanks for looking at this.