Re: isearch region or thing at point.

[Ergus]

Hi Eli:

This patch has changed a lot because some others made suggestions I
considered useful. I will attach the new patch in another mail.

On the other hand it makes sense that M-w should be used in case the
user wants to add the text in the minibuffer to the kill-ring.
(Something like isearchp-kill-ring-save)

So maybe M-r (region) or M-i (insert) must be used for what I propose
and Drew may add the isearch-kill-ring-save function he wrote and bind
it to M-w. That way there will be all the copy functionalities in place.

But then we must recommend bind M-r or M-i (or whatever) for similar
functionalities. And if possible correct other modes to be consistent
with that (if that does not start a religious war here please).

I will try to do the same for replace-like commands.

On Sat, May 04, 2019 at 12:26:56PM +0300, Eli Zaretskii wrote:
> > Date: Wed, 1 May 2019 13:20:25 +0200
> > From: Ergus <address@hidden>
> > Cc: Juri Linkov <address@hidden>, address@hidden
> >
> > address@hidden M-w @r{(Incremental search)}
> > address@hidden isearch-yank-region
> > +  @kbd{M-w} (@code{isearch-yank-region}) appends the text in the
> > +active region if @code{transient-mark-mode} is @code{non-nil}. This is
> > +an easy way to insert the text in the region without needing to exit
> > address@hidden The region is deactivated during the search, but
> > +it is reactivated if the @code{isearch-cancel} is called.
>
> Please leave 2 spaces between sentences in all documentation and
> comments.
>
> > +       ;; set it to nil so that isearch's messages don't get timed out.
>
> Comments should start with a capital letter.
>
> Thanks.