[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] Changes to emacs/src/xdisp.c
From: |
Kim F. Storm |
Subject: |
[Emacs-diffs] Changes to emacs/src/xdisp.c |
Date: |
Thu, 22 Aug 2002 12:52:56 -0400 |
Index: emacs/src/xdisp.c
diff -c emacs/src/xdisp.c:1.776 emacs/src/xdisp.c:1.777
*** emacs/src/xdisp.c:1.776 Fri Aug 9 13:29:11 2002
--- emacs/src/xdisp.c Thu Aug 22 12:52:56 2002
***************
*** 10365,10371 ****
}
if (!make_cursor_line_fully_visible (w))
! goto try_to_scroll;
#if GLYPH_DEBUG
debug_method_add (w, "forced window start");
#endif
--- 10365,10408 ----
}
if (!make_cursor_line_fully_visible (w))
! {
! /* CVS rev. 1.761 had changed this to ``goto try_to_scroll''.
!
! The intention of the fix -- AFAIU -- was to ensure that
! the cursor didn't end up on a partially visible last (or
! first?) line when scrolling.
!
!
! But that change causes havoc when scrolling backwards and
! a partially visible first (or last?) line is present when
! we reach the top of the buffer. In effect, the text
! already in the window is repeated (each line is appended
! to the same or another lines in the window)...
!
! I changed it back to ``goto need_larger_matrices'' which
! in effect mean that we don't go through `try_scrolling'
! when the cursor is already at the first line of the buffer,
! and there is really only a few pixels [rather than lines]
! to scroll backwards. I guess move_it_by_lines etc. really
! isn't the right device for doing that, ref. the code in
! make_cursor_line_fully_visible which was also disabled by
! CVS rev. 1.761.
!
! But how do we know that we are already on the top line of
! the window showing the first line in the buffer, so that
! scrolling really wont help here?
!
! I cannot find a simple fix for this (I tried various
! approaches), but I prefer to an occasional partial line
! rather than the visual messup, so I reverted this part of
! the fix.
!
! Someone will need to look into this when time allows.
!
! -- 2002-08-22, Kim F. Storm */
!
! goto need_larger_matrices;
! }
#if GLYPH_DEBUG
debug_method_add (w, "forced window start");
#endif
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Gerd Moellmann, 2002/08/03
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Richard M. Stallman, 2002/08/05
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Gerd Moellmann, 2002/08/09
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Gerd Moellmann, 2002/08/09
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Kenichi Handa, 2002/08/20
- [Emacs-diffs] Changes to emacs/src/xdisp.c,
Kim F. Storm <=
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Kenichi Handa, 2002/08/26
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Kenichi Handa, 2002/08/26
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Richard M. Stallman, 2002/08/29
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Kim F. Storm, 2002/08/30
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Kenichi Handa, 2002/08/30
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Kenichi Handa, 2002/08/30
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Stefan Monnier, 2002/08/30
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Kim F. Storm, 2002/08/30
- [Emacs-diffs] Changes to emacs/src/xdisp.c, Eli Zaretskii, 2002/08/31