[Emacs-diffs] Changes to emacs/src/xfaces.c

[Richard M . Stallman]

Index: emacs/src/xfaces.c
diff -c emacs/src/xfaces.c:1.305 emacs/src/xfaces.c:1.306
*** emacs/src/xfaces.c:1.305    Tue Sep 14 20:04:09 2004
--- emacs/src/xfaces.c  Sun Nov  7 03:47:09 2004
***************
*** 3432,3439 ****
     call into lisp.  */
  
  Lisp_Object
! merge_face_heights (from, to, invalid, gcpro)
!      Lisp_Object from, to, invalid, gcpro;
  {
    Lisp_Object result = invalid;
  
--- 3432,3439 ----
     call into lisp.  */
  
  Lisp_Object
! merge_face_heights (from, to, invalid)
!      Lisp_Object from, to, invalid;
  {
    Lisp_Object result = invalid;
  
***************
*** 3458,3473 ****
        /* Call function with current height as argument.
         From is the new height.  */
        Lisp_Object args[2];
-       struct gcpro gcpro1;
- 
-       GCPRO1 (gcpro);
  
        args[0] = from;
        args[1] = to;
        result = safe_call (2, args);
  
-       UNGCPRO;
- 
        /* Ensure that if TO was absolute, so is the result.  */
        if (INTEGERP (to) && !INTEGERP (result))
        result = invalid;
--- 3458,3468 ----
***************
*** 3520,3527 ****
      if (!UNSPECIFIEDP (from[i]))
        {
        if (i == LFACE_HEIGHT_INDEX && !INTEGERP (from[i]))
!         to[i] = merge_face_heights (from[i], to[i], to[i],
!                                     named_merge_points);
        else
          to[i] = from[i];
        }
--- 3515,3521 ----
      if (!UNSPECIFIEDP (from[i]))
        {
        if (i == LFACE_HEIGHT_INDEX && !INTEGERP (from[i]))
!         to[i] = merge_face_heights (from[i], to[i], to[i]);
        else
          to[i] = from[i];
        }
***************
*** 3548,3558 ****
    if (push_named_merge_point (&named_merge_point,
                              face_name, &named_merge_points))
      {
        Lisp_Object from[LFACE_VECTOR_SIZE];
        int ok = get_lface_attributes (f, face_name, from, 0);
  
        if (ok)
!       merge_face_vectors (f, from, to, named_merge_points);
  
        return ok;
      }
--- 3542,3557 ----
    if (push_named_merge_point (&named_merge_point,
                              face_name, &named_merge_points))
      {
+       struct gcpro gcpro1;
        Lisp_Object from[LFACE_VECTOR_SIZE];
        int ok = get_lface_attributes (f, face_name, from, 0);
  
        if (ok)
!       {
!         GCPRO1 (named_merge_point.face_name);
!         merge_face_vectors (f, from, to, named_merge_points);
!         UNGCPRO;
!       }
  
        return ok;
      }
***************
*** 3643,3650 ****
              else if (EQ (keyword, QCheight))
                {
                  Lisp_Object new_height =
!                   merge_face_heights (value, to[LFACE_HEIGHT_INDEX],
!                                       Qnil, Qnil);
  
                  if (! NILP (new_height))
                    to[LFACE_HEIGHT_INDEX] = new_height;
--- 3642,3648 ----
              else if (EQ (keyword, QCheight))
                {
                  Lisp_Object new_height =
!                   merge_face_heights (value, to[LFACE_HEIGHT_INDEX], Qnil);
  
                  if (! NILP (new_height))
                    to[LFACE_HEIGHT_INDEX] = new_height;
***************
*** 4031,4037 ****
                  /* The default face must have an absolute size,
                     otherwise, we do a test merge with a random
                     height to see if VALUE's ok. */
!                 : merge_face_heights (value, make_number (10), Qnil, Qnil));
  
          if (!INTEGERP (test) || XINT (test) <= 0)
            signal_error ("Invalid face height", value);
--- 4029,4035 ----
                  /* The default face must have an absolute size,
                     otherwise, we do a test merge with a random
                     height to see if VALUE's ok. */
!                 : merge_face_heights (value, make_number (10), Qnil));
  
          if (!INTEGERP (test) || XINT (test) <= 0)
            signal_error ("Invalid face height", value);
***************
*** 4737,4743 ****
    if (EQ (value1, Qunspecified))
      return value2;
    else if (EQ (attribute, QCheight))
!     return merge_face_heights (value1, value2, value1, Qnil);
    else
      return value1;
  }
--- 4735,4741 ----
    if (EQ (value1, Qunspecified))
      return value2;
    else if (EQ (attribute, QCheight))
!     return merge_face_heights (value1, value2, value1);
    else
      return value1;
  }