[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] Changes to emacs/lisp/bookmark.el,v

From: Bastien Guerry
Subject: [Emacs-diffs] Changes to emacs/lisp/bookmark.el,v
Date: Fri, 07 Mar 2008 19:32:01 +0000

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Bastien Guerry <bastien1>       08/03/07 19:32:00

Index: bookmark.el
RCS file: /sources/emacs/emacs/lisp/bookmark.el,v
retrieving revision 1.104
retrieving revision 1.105
diff -u -b -r1.104 -r1.105
--- bookmark.el 7 Mar 2008 17:03:36 -0000       1.104
+++ bookmark.el 7 Mar 2008 19:31:59 -0000       1.105
@@ -314,6 +314,7 @@
 ;; know anything about the format of bookmark-alist entries.
 ;; Everyone else should go through them.
 (defun bookmark-name-from-full-record (full-record)
   "Return name of FULL-RECORD \(an alist element instead of a string\)."
   (car full-record))
@@ -463,6 +464,13 @@
     (setq bookmark-history (cons ,string bookmark-history))))
+(defvar bookmark-make-name-function nil
+  "A function that should be called to return the name of the bookmark.
+When called with an argument, the function should return a file
+name -- or whatever is required to jump to the location.  Modes
+may set this variable buffer-locally to enable a default name to
+be proposed when calling `bookmark-set'.")
 (defvar bookmark-make-record-function 'bookmark-make-record-for-text-file
   "A function that should be called to create a bookmark record.
 Modes may set this variable buffer-locally to enable bookmarking of
@@ -738,7 +746,6 @@
 the list of bookmarks.\)"
   (interactive (list nil current-prefix-arg))
-   (local-variable-p 'bookmark-make-record-function)
    (error "Buffer not visiting a file or directory"))
@@ -947,8 +954,9 @@
   "Return the name of the current buffer's file, non-directory.
 In Info, return the current node."
-   ;; Are we in Info?
-   ((derived-mode-p 'Info-mode) Info-current-node)
+   ;; Is the mode defining the bookmark buffer name?
+   (bookmark-make-name-function
+    (funcall bookmark-make-name-function))
    ;; Or are we a file?
    (buffer-file-name (file-name-nondirectory buffer-file-name))
    ;; Or are we a directory?
@@ -988,8 +996,10 @@
   "Return the current buffer's file in a way useful for bookmarks.
 For example, if this is a Info buffer, return the Info file's name."
-   ((eq major-mode 'Info-mode)
-    Info-current-file)
+   ;; Return the location the handler should jump to
+   ;; E.g. the Info file name for the Info handler
+   (bookmark-make-name-function
+    (funcall bookmark-make-name-function t))
     ;; Abbreviate the path, both so it's shorter and so it's more
     ;; portable.  E.g., the user's home dir might be a different

reply via email to

[Prev in Thread] Current Thread [Next in Thread]