[Emacs-diffs] emacs/lisp ChangeLog net/ldap.el

[Stefan Monnier]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Stefan Monnier <monnier>        09/08/30 14:24:12

Modified files:
        lisp           : ChangeLog 
        lisp/net       : ldap.el 

Log message:
        (ldap-search-internal): Use with-current-buffer and push.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.16064&r2=1.16065
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/net/ldap.el?cvsroot=emacs&r1=1.32&r2=1.33

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.16064
retrieving revision 1.16065
diff -u -b -r1.16064 -r1.16065
--- ChangeLog   30 Aug 2009 14:23:21 -0000      1.16064
+++ ChangeLog   30 Aug 2009 14:24:09 -0000      1.16065
@@ -1,5 +1,7 @@
 2009-08-30  Stefan Monnier  <address@hidden>
 
+       * net/ldap.el (ldap-search-internal): Use with-current-buffer and push.
+
        * net/imap.el (imap-send-command): Simplify.
        (imap-wait-for-tag): point-max - buffer-size.
 

Index: net/ldap.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/net/ldap.el,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -b -r1.32 -r1.33
--- net/ldap.el 5 Jan 2009 03:22:45 -0000       1.32
+++ net/ldap.el 30 Aug 2009 14:24:12 -0000      1.33
@@ -524,8 +524,7 @@
            (equal "" filter))
        (error "No search filter"))
     (setq filter (cons filter attributes))
-    (save-excursion
-      (set-buffer buf)
+    (with-current-buffer buf
       (erase-buffer)
       (if (and host
               (not (equal "" host)))
@@ -597,8 +596,7 @@
            ;; Do not try to open non-existent files
            (if (equal value "")
                (setq value " ")
-             (save-excursion
-               (set-buffer bufval)
+             (with-current-buffer bufval
                (erase-buffer)
                (set-buffer-multibyte nil)
                (insert-file-contents-literally value)
@@ -607,9 +605,9 @@
            (setq record (cons (list name value)
                               record))
            (forward-line 1))
-         (setq result (cons (if withdn
+         (push (if withdn
                                 (cons dn (nreverse record))
-                              (nreverse record)) result))
+                 (nreverse record)) result)
          (setq record nil)
          (skip-chars-forward " \t\n")
          (message "Parsing results... %d" numres)