[Emacs-diffs] emacs/lisp ChangeLog emacs-lisp/elint.el

[Glenn Morris]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Glenn Morris <gm>       09/09/14 00:48:10

Modified files:
        lisp           : ChangeLog 
        lisp/emacs-lisp: elint.el 

Log message:
        (elint-add-required-env): Revert to not using temp-buffers (2009-09-12).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.16163&r2=1.16164
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/emacs-lisp/elint.el?cvsroot=emacs&r1=1.29&r2=1.30

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.16163
retrieving revision 1.16164
diff -u -b -r1.16163 -r1.16164
--- ChangeLog   13 Sep 2009 22:28:57 -0000      1.16163
+++ ChangeLog   14 Sep 2009 00:48:06 -0000      1.16164
@@ -1,3 +1,8 @@
+2009-09-14  Glenn Morris  <address@hidden>
+
+       * emacs-lisp/elint.el (elint-add-required-env): Revert to not using
+       temp-buffers (2009-09-12).
+
 2009-09-13  Stefan Monnier  <address@hidden>
 
        * textmodes/ispell.el (ispell-command-loop): Improve last fix, using

Index: emacs-lisp/elint.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/elint.el,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -b -r1.29 -r1.30
--- emacs-lisp/elint.el 12 Sep 2009 22:32:55 -0000      1.29
+++ emacs-lisp/elint.el 14 Sep 2009 00:48:10 -0000      1.30
@@ -352,14 +352,17 @@
        (message nil)
        (if lib
            (save-excursion
-             ;;; (set-buffer (find-file-noselect lib))
-             ;;; (elint-update-env)
-             ;;; (setq env (elint-env-add-env env elint-buffer-env)))
-             (with-temp-buffer
-               (insert-file-contents lib)
-               (with-syntax-table emacs-lisp-mode-syntax-table
-                 (elint-update-env))
-               (setq env (elint-env-add-env env elint-buffer-env))))
+             ;; FIXME this doesn't use a temp buffer, because it
+             ;; stores the result in buffer-local variables so that
+             ;; it can be reused.
+             (set-buffer (find-file-noselect lib))
+             (elint-update-env)
+             (setq env (elint-env-add-env env elint-buffer-env)))
+             ;;; (with-temp-buffer
+             ;;;       (insert-file-contents lib)
+             ;;;       (with-syntax-table emacs-lisp-mode-syntax-table
+             ;;;         (elint-update-env))
+             ;;;       (setq env (elint-env-add-env env elint-buffer-env))))
              ;;(message "Elint processed (require '%s)" name))
          (error "Unable to find require'd library %s" name)))
     (error