[Emacs-diffs] emacs/lisp ChangeLog emacs-lisp/elint.el

[Glenn Morris]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Glenn Morris <gm>       09/11/14 19:57:12

Modified files:
        lisp           : ChangeLog 
        lisp/emacs-lisp: elint.el 

Log message:
        (elint-standard-variables): Doc fix.
        
        Add some comments related to #1063.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.16630&r2=1.16631
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/emacs-lisp/elint.el?cvsroot=emacs&r1=1.33&r2=1.34

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.16630
retrieving revision 1.16631
diff -u -b -r1.16630 -r1.16631
--- ChangeLog   14 Nov 2009 19:55:37 -0000      1.16630
+++ ChangeLog   14 Nov 2009 19:57:09 -0000      1.16631
@@ -1,3 +1,7 @@
+2009-11-14  Glenn Morris  <address@hidden>
+
+       * emacs-lisp/elint.el (elint-standard-variables): Doc fix.
+
 2009-11-14  Shigeru Fukaya  <address@hidden>
 
        * emacs-lisp/elint.el (elint-standard-variables): Add some variables

Index: emacs-lisp/elint.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/elint.el,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -b -r1.33 -r1.34
--- emacs-lisp/elint.el 14 Nov 2009 19:55:40 -0000      1.33
+++ emacs-lisp/elint.el 14 Nov 2009 19:57:12 -0000      1.34
@@ -118,13 +118,15 @@
 ;;; Data
 ;;;
 
-;; FIXME does this serve any useful purpose now elint-builtin-variables exists?
 (defconst elint-standard-variables
+  ;; Most of these are defined in C with no documentation.
+  ;; FIXME I don't see why they shouldn't just get doc-strings.
   '(vc-mode local-write-file-hooks activate-menubar-hook buffer-name-history
            coding-system-history extended-command-history
            kbd-macro-termination-hook read-expression-history
            yes-or-no-p-history)
-  "Standard buffer local variables, excluding `elint-builtin-variables'.")
+  "Standard variables, excluding `elint-builtin-variables'.
+These are variables that we cannot detect automatically for some reason.")
 
 (defvar elint-builtin-variables nil
   "List of built-in variables.  Set by `elint-initialize'.
@@ -638,6 +640,13 @@
 
 (defun elint-unbound-variable (var env)
   "T if VAR is unbound in ENV."
+  ;; #1063 suggests adding (symbol-file var) here, but I don't think
+  ;; this is right, because it depends on what files you happen to have
+  ;; loaded at the time, which might not be the same when the code runs.
+  ;; It also suggests adding:
+  ;; (numberp (get var 'variable-documentation))
+  ;; (numberp (cdr-safe (get var 'variable-documentation)))
+  ;; but this is not needed now elint-scan-doc-file exists.
   (not (or (memq var '(nil t))
           (eq var elint-bound-variable)
           (elint-env-find-var env var)