emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r101544: Fix bug#6820: Don't accept b


From: Juanma Barranquero
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r101544: Fix bug#6820: Don't accept backslashes or quotes on compiler options.
Date: Thu, 23 Sep 2010 01:14:00 +0200
User-agent: Bazaar (2.0.3)

------------------------------------------------------------
revno: 101544
committer: Juanma Barranquero <address@hidden>
branch nick: trunk
timestamp: Thu 2010-09-23 01:14:00 +0200
message:
  Fix bug#6820: Don't accept backslashes or quotes on compiler options.
  
  * nt/configure.bat: Err out when the argument of --cflags contains
    invalid characters (check implemented only for GCC).
modified:
  nt/ChangeLog
  nt/configure.bat
=== modified file 'nt/ChangeLog'
--- a/nt/ChangeLog      2010-08-19 16:38:41 +0000
+++ b/nt/ChangeLog      2010-09-22 23:14:00 +0000
@@ -1,3 +1,8 @@
+2010-09-22  Juanma Barranquero  <address@hidden>
+
+       * configure.bat: Err out when the argument of --cflags contains
+       invalid characters (check implemented only for GCC).  (Bug#6820)
+
 2010-08-19  Juanma Barranquero  <address@hidden>
 
        * addpm.c (add_registry): Create App Paths of type REG_EXPAND_SZ.

=== modified file 'nt/configure.bat'
--- a/nt/configure.bat  2010-09-22 17:26:02 +0000
+++ b/nt/configure.bat  2010-09-22 23:14:00 +0000
@@ -358,9 +358,25 @@
 @echo gcc %cf% -c junk.c >>config.log
 gcc %cf% -c junk.c >>config.log 2>&1
 set cf=
+if exist junk.o goto chkuser
+echo The failed program was: >>config.log
+type junk.c >>config.log
+goto nocompiler
+
+:chkuser
+rm -f junk.o
+echo int main (int argc, char *argv[]) {>junk.c
+echo char *usercflags = "%usercflags%";>>junk.c
+echo }>>junk.c
+echo gcc -Werror -c junk.c >>config.log
+gcc -Werror -c junk.c >>config.log 2>&1
 if exist junk.o goto gccOk
-echo The failed program was: >>config.log
-type junk.c >>config.log
+echo.
+echo Error in --cflags argument: %usercflags%
+echo Backslashes and quotes cannot be used with --cflags.  Please use forward
+echo slashes for filenames and paths (e.g. when passing directories to -I).
+rm -f junk.c
+goto end
 
 :nocompiler
 echo.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]