[Emacs-diffs] /srv/bzr/emacs/trunk r104496: lisp/doc-view.el: Silence compiler warning.

[Juanma Barranquero]

------------------------------------------------------------
revno: 104496
committer: Juanma Barranquero <address@hidden>
branch nick: trunk
timestamp: Sun 2011-06-05 02:18:46 +0200
message:
  lisp/doc-view.el: Silence compiler warning.
modified:
  lisp/ChangeLog
  lisp/doc-view.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2011-06-04 22:46:26 +0000
+++ b/lisp/ChangeLog    2011-06-05 00:18:46 +0000
@@ -1,3 +1,8 @@
+2011-06-05  Juanma Barranquero  <address@hidden>
+
+       * doc-view.el (doc-view-remove-if): Move computation of result out
+       of `dolist' to silence misleading lexical-binding warning.
+
 2011-06-04  Chong Yidong  <address@hidden>
 
        * emacs-lisp/timer.el (timer-activate): Remove unused arg.

=== modified file 'lisp/doc-view.el'
--- a/lisp/doc-view.el  2011-05-10 02:31:42 +0000
+++ b/lisp/doc-view.el  2011-06-05 00:18:46 +0000
@@ -614,9 +614,10 @@
 (defun doc-view-remove-if (predicate list)
   "Return LIST with all items removed that satisfy PREDICATE."
   (let (new-list)
-    (dolist (item list (nreverse new-list))
+    (dolist (item list)
       (when (not (funcall predicate item))
-       (setq new-list (cons item new-list))))))
+       (setq new-list (cons item new-list))))
+     (nreverse new-list)))
 
 ;;;###autoload
 (defun doc-view-mode-p (type)