[Emacs-diffs] /srv/bzr/emacs/trunk r110432: * lisp/subr.el (read-passwd-map): Don't use `defconst'.

[Stefan Monnier]

------------------------------------------------------------
revno: 110432
fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12597
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Sun 2012-10-07 15:48:02 -0400
message:
  * lisp/subr.el (read-passwd-map): Don't use `defconst'.
  (read-passwd): Remove a few more potential sources of leaks.
modified:
  lisp/ChangeLog
  lisp/newcomment.el
  lisp/subr.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-10-07 19:37:37 +0000
+++ b/lisp/ChangeLog    2012-10-07 19:48:02 +0000
@@ -1,7 +1,12 @@
+2012-10-07  Stefan Monnier  <address@hidden>
+
+       * subr.el (read-passwd-map): Don't use `defconst' (bug#12597).
+       (read-passwd): Remove a few more potential sources of leaks.
+
 2012-10-07  Fabián Ezequiel Gallina  <address@hidden>
 
        * progmodes/python.el (inferior-python-mode)
-       (python-shell-make-comint): Fixed initialization of local
+       (python-shell-make-comint): Fix initialization of local
        variables copied from parent buffer.
 
 2012-10-07  Jan Djärv  <address@hidden>

=== modified file 'lisp/newcomment.el'
--- a/lisp/newcomment.el        2012-08-15 16:29:11 +0000
+++ b/lisp/newcomment.el        2012-10-07 19:48:02 +0000
@@ -327,8 +327,8 @@
 ;;;###autoload
 (defun comment-normalize-vars (&optional noerror)
   "Check and setup the variables needed by other commenting functions.
-Functions autoloaded from newcomment.el, being entry points, should call
-this function before any other, so the rest of the code can assume that
+Any command calling functions from newcomment.el, being entry points, should
+call this function before any other, so the rest of the code can assume that
 the variables are properly set."
   (unless (and (not comment-start) noerror)
     (unless comment-start

=== modified file 'lisp/subr.el'
--- a/lisp/subr.el      2012-10-06 17:29:15 +0000
+++ b/lisp/subr.el      2012-10-07 19:48:02 +0000
@@ -2143,7 +2143,9 @@
       (setq first nil))
     code))
 
-(defconst read-passwd-map
+(defvar read-passwd-map
+  ;; BEWARE: `defconst' would purecopy it, breaking the sharing with
+  ;; minibuffer-local-map along the way!
   (let ((map (make-sparse-keymap)))
     (set-keymap-parent map minibuffer-local-map)
     (define-key map "\C-u" #'delete-minibuffer-contents) ;bug#12570
@@ -2186,7 +2188,9 @@
           (lambda ()
             (setq minibuf (current-buffer))
             ;; Turn off electricity.
-            (set (make-local-variable 'post-self-insert-hook) nil)
+            (setq-local post-self-insert-hook nil)
+            (setq-local buffer-undo-list t)
+            (setq-local select-active-regions nil)
             (use-local-map read-passwd-map)
             (add-hook 'after-change-functions hide-chars-fun nil 'local))
         (unwind-protect