[Emacs-diffs] /srv/bzr/emacs/trunk r110968: Remove -p suffix from set-face-* functions

[Glenn Morris]

------------------------------------------------------------
revno: 110968
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Wed 2012-11-21 00:27:13 -0800
message:
  Remove -p suffix from set-face-* functions
  
  * lisp/faces.el (set-face-inverse-video, set-face-bold, set-face-italic):
  Remove -p suffix from names, for consistency with other set-face-*.
  (set-face-inverse-video): Fix interactive spec.
  * lisp/play/gamegrid.el (gamegrid-make-mono-tty-face):
  * lisp/textmodes/table.el (table--update-cell-face):
  Use set-face-inverse-video rather than now obsolete alias.
  
  * doc/lispref/display.texi (Attribute Functions):
  Update for set-face-* name changes.
modified:
  doc/lispref/ChangeLog
  doc/lispref/display.texi
  lisp/ChangeLog
  lisp/faces.el
  lisp/play/gamegrid.el
  lisp/textmodes/table.el

=== modified file 'doc/lispref/ChangeLog'
--- a/doc/lispref/ChangeLog     2012-11-21 04:47:55 +0000
+++ b/doc/lispref/ChangeLog     2012-11-21 08:27:13 +0000
@@ -1,5 +1,8 @@
 2012-11-21  Glenn Morris  <address@hidden>
 
+       * display.texi (Attribute Functions):
+       Update for set-face-* name changes.
+
        * debugging.texi (Profiling): New section.
        (Debugging): Mention profiling in the introduction.
        * tips.texi (Compilation Tips): Move profiling to separate section.

=== modified file 'doc/lispref/display.texi'
--- a/doc/lispref/display.texi  2012-11-17 02:29:58 +0000
+++ b/doc/lispref/display.texi  2012-11-21 08:27:13 +0000
@@ -2425,12 +2425,12 @@
 This sets the @code{:font} attribute of @var{face} to @var{font}.
 @end deffn
 
address@hidden set-face-bold-p face bold-p &optional frame
address@hidden set-face-bold face bold-p &optional frame
 This sets the @code{:weight} attribute of @var{face} to @var{normal}
 if @var{bold-p} is @code{nil}, and to @var{bold} otherwise.
 @end defun
 
address@hidden set-face-italic-p face italic-p &optional frame
address@hidden set-face-italic face italic-p &optional frame
 This sets the @code{:slant} attribute of @var{face} to @var{normal} if
 @var{italic-p} is @code{nil}, and to @var{italic} otherwise.
 @end defun
@@ -2440,7 +2440,7 @@
 @var{underline}.
 @end defun
 
address@hidden set-face-inverse-video-p face inverse-video-p &optional frame
address@hidden set-face-inverse-video face inverse-video-p &optional frame
 This sets the @code{:inverse-video} attribute of @var{face} to
 @var{inverse-video-p}.
 @end defun

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-11-21 04:47:55 +0000
+++ b/lisp/ChangeLog    2012-11-21 08:27:13 +0000
@@ -1,3 +1,12 @@
+2012-11-21  Glenn Morris  <address@hidden>
+
+       * faces.el (set-face-inverse-video, set-face-bold, set-face-italic):
+       Remove -p suffix from names, for consistency with other set-face-*.
+       (set-face-inverse-video): Fix interactive spec.
+       * play/gamegrid.el (gamegrid-make-mono-tty-face):
+       * textmodes/table.el (table--update-cell-face):
+       Use set-face-inverse-video rather than now obsolete alias.
+
 2012-11-21  Eli Zaretskii  <address@hidden>
 
        * simple.el (line-move): Don't call line-move-partial if

=== modified file 'lisp/faces.el'
--- a/lisp/faces.el     2012-11-16 02:44:02 +0000
+++ b/lisp/faces.el     2012-11-21 08:27:13 +0000
@@ -862,7 +862,7 @@
                                 'set-face-underline "24.3")
 
 
-(defun set-face-inverse-video-p (face inverse-video-p &optional frame)
+(defun set-face-inverse-video (face inverse-video-p &optional frame)
   "Specify whether face FACE is in inverse video.
 INVERSE-VIDEO-P non-nil means FACE displays explicitly in inverse video.
 INVERSE-VIDEO-P nil means FACE explicitly is not in inverse video.
@@ -870,14 +870,13 @@
 Use `set-face-attribute' to ``unspecify'' the inverse video attribute."
   (interactive
    (let ((list (read-face-and-attribute :inverse-video)))
-     (list (car list) (eq (car (cdr list)) t))))
+     (list (car list) (if (cadr list) t))))
   (set-face-attribute face frame :inverse-video inverse-video-p))
 
+(define-obsolete-function-alias 'set-face-inverse-video-p
+                                'set-face-inverse-video "24.4")
 
-;; The -p suffix is a hostage to fortune.  What if we want to extend
-;; this to allow more than boolean options?  Exactly this happened
-;; to set-face-underline-p.
-(defun set-face-bold-p (face bold-p &optional frame)
+(defun set-face-bold (face bold-p &optional frame)
   "Specify whether face FACE is bold.
 BOLD-P non-nil means FACE should explicitly display bold.
 BOLD-P nil means FACE should explicitly display non-bold.
@@ -887,8 +886,10 @@
       (make-face-unbold face frame)
     (make-face-bold face frame)))
 
-
-(defun set-face-italic-p (face italic-p &optional frame)
+(define-obsolete-function-alias 'set-face-bold-p 'set-face-bold "24.4")
+
+
+(defun set-face-italic (face italic-p &optional frame)
   "Specify whether face FACE is italic.
 ITALIC-P non-nil means FACE should explicitly display italic.
 ITALIC-P nil means FACE should explicitly display non-italic.
@@ -898,6 +899,8 @@
       (make-face-unitalic face frame)
     (make-face-italic face frame)))
 
+(define-obsolete-function-alias 'set-face-italic-p 'set-face-italic "24.4")
+
 
 (defalias 'set-face-background-pixmap 'set-face-stipple)
 

=== modified file 'lisp/play/gamegrid.el'
--- a/lisp/play/gamegrid.el     2012-11-17 07:00:35 +0000
+++ b/lisp/play/gamegrid.el     2012-11-21 08:27:13 +0000
@@ -175,7 +175,7 @@
 
 (defun gamegrid-make-mono-tty-face ()
   (let ((face (make-face 'gamegrid-mono-tty-face)))
-    (set-face-inverse-video-p face t)
+    (set-face-inverse-video face t)
     face))
 
 (defun gamegrid-make-color-tty-face (color)

=== modified file 'lisp/textmodes/table.el'
--- a/lisp/textmodes/table.el   2012-10-02 03:46:08 +0000
+++ b/lisp/textmodes/table.el   2012-11-21 08:27:13 +0000
@@ -5210,7 +5210,7 @@
   "Update cell face according to the current mode."
   (if (featurep 'xemacs)
       (set-face-property 'table-cell 'underline table-fixed-width-mode)
-    (set-face-inverse-video-p 'table-cell table-fixed-width-mode)))
+    (set-face-inverse-video 'table-cell table-fixed-width-mode)))
 
 (table--update-cell-face)