emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r111334: Revert static checking of st


From: Paul Eggert
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r111334: Revert static checking of stack smashing.
Date: Tue, 25 Dec 2012 21:41:42 -0800
User-agent: Bazaar (2.5.0)

------------------------------------------------------------
revno: 111334
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Tue 2012-12-25 21:41:42 -0800
message:
  Revert static checking of stack smashing.
  
  * configure.ac (WARN_CFLAGS): Omit -Wstack-protector when
  configured with --enable-gcc-warnings.  -Wstack-protector causes
  diagnostics to be issued on Ubuntu 12.10 x86-64.
modified:
  ChangeLog
  configure.ac
=== modified file 'ChangeLog'
--- a/ChangeLog 2012-12-24 06:24:08 +0000
+++ b/ChangeLog 2012-12-26 05:41:42 +0000
@@ -1,3 +1,10 @@
+2012-12-26  Paul Eggert  <address@hidden>
+
+       Revert static checking of stack smashing.
+       * configure.ac (WARN_CFLAGS): Omit -Wstack-protector when
+       configured with --enable-gcc-warnings.  -Wstack-protector causes
+       diagnostics to be issued on Ubuntu 12.10 x86-64.
+
 2012-12-24  Paul Eggert  <address@hidden>
 
        Merge from gnulib, incorporating:

=== modified file 'configure.ac'
--- a/configure.ac      2012-12-21 19:32:43 +0000
+++ b/configure.ac      2012-12-26 05:41:42 +0000
@@ -727,23 +727,12 @@
   # <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
   nw="$nw -Wshadow"
 
+  # Emacs's use of alloca inhibits protecting the stack.
+  nw="$nw -Wstack-protector"
+
   # The following line should be removable at some point.
   nw="$nw -Wsuggest-attribute=pure"
 
-  AC_MSG_CHECKING([whether to use -Wstack-protector])
-  AC_PREPROC_IFELSE(
-    [AC_LANG_PROGRAM(
-       [[#if (1 <= __LONG_MAX__ >> 31 >> 31 \
-           && 4 < __GNUC__ + (7 < __GNUC_MINOR__ + (2 <= __GNUC_PATCHLEVEL__)))
-          /* OK */
-         #else
-          #error "Not GCC, or GCC before 4.7.2, or 'long int' has < 64 bits."
-        #endif
-       ]])],
-    [AC_MSG_RESULT(yes)],
-    [AC_MSG_RESULT(no)
-     nw="$nw -Wstack-protector"])
-
   gl_MANYWARN_ALL_GCC([ws])
   gl_MANYWARN_COMPLEMENT([ws], [$ws], [$nw])
   for w in $ws; do


reply via email to

[Prev in Thread] Current Thread [Next in Thread]