Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112522: * lisp/progmodes/ruby-mode.el: First cut at SMIE support.

[Dmitry Gutov]

Stefan,

> revno: 112522
> === modified file 'test/indent/ruby.rb'
> --- a/test/indent/ruby.rb     2012-08-14 12:38:11 +0000
> +++ b/test/indent/ruby.rb     2013-05-08 20:25:57 +0000
> @@ -21,6 +21,40 @@
>  # Highlight the regexp after "if".
>  x = toto / foo if /do bar/ =~ "dobar"
>  
> +def test1(arg)
> +  puts "hello"
> +end
> +
> +def test2 (arg)
> +  a = "apple"
> +
> +  if a == 2
> +    puts "hello"
> +  else
> +    puts "there"
> +  end

Don't you think it would be better to have these tests in
test/automated/ruby-mode-tests.el?

Having examples in ruby.rb that one has to check manually makes certain
sense for syntax highligting, but automated indentation tests are easier
to read and run.

By the way, if you're going to return to this in the near future, I'd
suggest you take a look at the automated tests. With SMIE enabled, a few
of them fail and at least one infloops.