emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] trunk r114163: Port --without-x --enable-gcc-warnings to F


From: Paul Eggert
Subject: [Emacs-diffs] trunk r114163: Port --without-x --enable-gcc-warnings to Fedora 19.
Date: Sat, 07 Sep 2013 00:21:00 +0000
User-agent: Bazaar (2.6b2)

------------------------------------------------------------
revno: 114163
revision-id: address@hidden
parent: address@hidden
committer: Paul Eggert <address@hidden>
branch nick: trunk
timestamp: Fri 2013-09-06 17:20:56 -0700
message:
  Port --without-x --enable-gcc-warnings to Fedora 19.
  
  * configure.ac (WERROR_CFLAGS): Omit redundant use of
  -Wmissing-field-initializers, -Wswitch, -Wtype-limits,
  -Wunused-parameter.  If there is no window system, also omit
  -Wsuggest-attribute=const and -Wsuggest-attribute=noreturn; this
  is needed for Fedora 19.
  * src/gfilenotify.c (globals_of_gfilenotify):
  Call g_type_init only if using an older glib version that needs it.
modified:
  ChangeLog                      changelog-20091113204419-o5vbwnq5f7feedwu-1538
  configure.ac                   
configure.in-20091113204419-o5vbwnq5f7feedwu-783
  src/ChangeLog                  changelog-20091113204419-o5vbwnq5f7feedwu-1438
  src/gfilenotify.c              gfilenotify.c-20130528100009-4z0x3dhiuzxnn8hq-1
=== modified file 'ChangeLog'
--- a/ChangeLog 2013-09-05 06:25:12 +0000
+++ b/ChangeLog 2013-09-07 00:20:56 +0000
@@ -1,3 +1,12 @@
+2013-09-07  Paul Eggert  <address@hidden>
+
+       Port --without-x --enable-gcc-warnings to Fedora 19.
+       * configure.ac (WERROR_CFLAGS): Omit redundant use of
+       -Wmissing-field-initializers, -Wswitch, -Wtype-limits,
+       -Wunused-parameter.  If there is no window system, also omit
+       -Wsuggest-attribute=const and -Wsuggest-attribute=noreturn; this
+       is needed for Fedora 19.
+
 2013-09-05  Dmitry Antipov  <address@hidden>
 
        Make --without-x compatible with --enable-gcc-warnings.

=== modified file 'configure.ac'
--- a/configure.ac      2013-09-05 06:25:12 +0000
+++ b/configure.ac      2013-09-07 00:20:56 +0000
@@ -826,6 +826,13 @@
   # The following line should be removable at some point.
   nw="$nw -Wsuggest-attribute=pure"
 
+  # This part is merely for shortening the command line,
+  # since -Wno-FOO needs to be added below regardless.
+  nw="$nw -Wmissing-field-initializers"
+  nw="$nw -Wswitch"
+  nw="$nw -Wtype-limits"
+  nw="$nw -Wunused-parameter"
+
   # clang is unduly picky about some things.
   AC_CACHE_CHECK([whether the compiler is clang], [emacs_cv_clang],
     [AC_COMPILE_IFELSE(
@@ -1777,6 +1784,11 @@
 
 if test "$window_system" = none && test "$gl_gcc_warnings" = yes; then
    # Too many warnings for now.
+   nw=
+   nw="$nw -Wsuggest-attribute=const"
+   nw="$nw -Wsuggest-attribute=noreturn"
+   gl_MANYWARN_COMPLEMENT([WARN_CFLAGS], [$WARN_CFLAGS], [$nw])
+
    gl_WARN_ADD([-Wno-unused-variable])
    gl_WARN_ADD([-Wno-unused-but-set-variable])
    gl_WARN_ADD([-Wno-unused-but-set-parameter])

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2013-09-06 16:40:12 +0000
+++ b/src/ChangeLog     2013-09-07 00:20:56 +0000
@@ -1,3 +1,9 @@
+2013-09-07  Paul Eggert  <address@hidden>
+
+       Port --without-x --enable-gcc-warnings to Fedora 19.
+       * gfilenotify.c (globals_of_gfilenotify):
+       Call g_type_init only if using an older glib version that needs it.
+
 2013-09-06  Dmitry Antipov  <address@hidden>
 
        * lisp.h (last_glyphless_glyph_frame, last_glyphless_glyph_face_id)

=== modified file 'src/gfilenotify.c'
--- a/src/gfilenotify.c 2013-07-16 16:39:42 +0000
+++ b/src/gfilenotify.c 2013-09-07 00:20:56 +0000
@@ -249,7 +249,9 @@
 void
 globals_of_gfilenotify (void)
 {
+#if ! GLIB_CHECK_VERSION (2, 36, 0)
   g_type_init ();
+#endif
   watch_list = Qnil;
 }
 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]