[Emacs-diffs] trunk r114251: * lisp/term/ns-win.el (parameters): Don't declare as dynamic.

[Stefan Monnier]

------------------------------------------------------------
revno: 114251
revision-id: address@hidden
parent: address@hidden
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Thu 2013-09-12 16:21:41 -0400
message:
  * lisp/term/ns-win.el (parameters): Don't declare as dynamic.
  (before-make-frame-hook): Don't add ineffective function.
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/term/ns-win.el            nswin.el-20091113204419-o5vbwnq5f7feedwu-8708

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2013-09-12 20:15:53 +0000
+++ b/lisp/ChangeLog    2013-09-12 20:21:41 +0000
@@ -1,5 +1,8 @@
 2013-09-12  Stefan Monnier  <address@hidden>
 
+       * term/ns-win.el (parameters): Don't declare as dynamic.
+       (before-make-frame-hook): Don't add ineffective function.
+
        * eshell/*.el: Use lexical-binding (bug#15231).
 
 2013-09-12  Kenichi Handa  <address@hidden>

=== modified file 'lisp/term/ns-win.el'
--- a/lisp/term/ns-win.el       2013-09-12 01:32:45 +0000
+++ b/lisp/term/ns-win.el       2013-09-12 20:21:41 +0000
@@ -556,29 +556,9 @@
   (interactive)
   (other-frame -1))
 
-;; If no position specified, make new frame offset by 25 from current.
-;; You'd think this was a window manager's job, but apparently without
-;; this, new frames open exactly on top of old ones (?).
-;; http://lists.gnu.org/archive/html/emacs-devel/2010-10/msg00988.html
-;; Note that AFAICS it is not documented that functions on
-;; before-make-frame-hook can access PARAMETERS.
-(defvar parameters)                 ; dynamically bound in make-frame
-(add-hook 'before-make-frame-hook
-          (lambda ()
-            (let ((left (cdr (assq 'left (frame-parameters))))
-                  (top (cdr (assq 'top (frame-parameters)))))
-              (if (consp left) (setq left (cadr left)))
-              (if (consp top) (setq top (cadr top)))
-              (cond
-               ((or (assq 'top parameters) (assq 'left parameters)))
-               ((or (not left) (not top)))
-               (t
-                (setq parameters (cons (cons 'left (+ left 25))
-                                       (cons (cons 'top (+ top 25))
-                                             parameters))))))))
-
-;; frame will be focused anyway, so select it
+;; Frame will be focused anyway, so select it
 ;; (if this is not done, mode line is dimmed until first interaction)
+;; FIXME: Sounds like we're working around a bug in the underlying code.
 (add-hook 'after-make-frame-functions 'select-frame)
 
 (defvar tool-bar-mode)