[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] trunk r114380: Address some "unused lexical argument" warn
From: |
Glenn Morris |
Subject: |
[Emacs-diffs] trunk r114380: Address some "unused lexical argument" warnings in erc |
Date: |
Thu, 19 Sep 2013 02:21:37 +0000 |
User-agent: |
Bazaar (2.6b2) |
------------------------------------------------------------
revno: 114380
revision-id: address@hidden
parent: address@hidden
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Wed 2013-09-18 19:21:31 -0700
message:
Address some "unused lexical argument" warnings in erc
* erc/erc.el (erc-open-server-buffer-p): Actually use the `buffer' arg.
* erc/erc-backend.el (erc-server-process-alive): Take optional `buffer' arg.
* erc/erc-button.el (erc-button-click-button, erc-button-press-button):
Mark unused arguments.
modified:
lisp/erc/ChangeLog changelog-20091113204419-o5vbwnq5f7feedwu-4305
lisp/erc/erc-backend.el
ercbackend.el-20091113204419-o5vbwnq5f7feedwu-4313
lisp/erc/erc-button.el
ercbutton.el-20091113204419-o5vbwnq5f7feedwu-4314
lisp/erc/erc.el erc.el-20091113204419-o5vbwnq5f7feedwu-4346
=== modified file 'lisp/erc/ChangeLog'
--- a/lisp/erc/ChangeLog 2013-09-18 01:48:00 +0000
+++ b/lisp/erc/ChangeLog 2013-09-19 02:21:31 +0000
@@ -1,3 +1,11 @@
+2013-09-19 Glenn Morris <address@hidden>
+
+ * erc-button.el (erc-button-click-button, erc-button-press-button):
+ Mark unused arguments.
+
+ * erc.el (erc-open-server-buffer-p): Actually use the `buffer' arg.
+ * erc-backend.el (erc-server-process-alive): Take optional `buffer' arg.
+
2013-09-18 Glenn Morris <address@hidden>
* erc-button.el (erc-button-add-buttons): Remove unused local vars.
=== modified file 'lisp/erc/erc-backend.el'
--- a/lisp/erc/erc-backend.el 2013-05-30 03:19:04 +0000
+++ b/lisp/erc/erc-backend.el 2013-09-19 02:21:31 +0000
@@ -497,11 +497,12 @@
erc-server-ping-handler)
erc-server-ping-timer-alist)))))
-(defun erc-server-process-alive ()
- "Return non-nil when `erc-server-process' is open or running."
- (and erc-server-process
- (processp erc-server-process)
- (memq (process-status erc-server-process) '(run open))))
+(defun erc-server-process-alive (&optional buffer)
+ "Return non-nil when BUFFER has an `erc-server-process' open or running."
+ (with-current-buffer (or buffer (current-buffer))
+ (and erc-server-process
+ (processp erc-server-process)
+ (memq (process-status erc-server-process) '(run open)))))
;;;; Connecting to a server
=== modified file 'lisp/erc/erc-button.el'
--- a/lisp/erc/erc-button.el 2013-09-18 01:48:00 +0000
+++ b/lisp/erc/erc-button.el 2013-09-19 02:21:31 +0000
@@ -407,7 +407,7 @@
;; Since Emacs runs this directly, rather than with
;; widget-button-click, we need to fake an extra arg in the
;; interactive spec.
-(defun erc-button-click-button (ignore event)
+(defun erc-button-click-button (_ignore event)
"Call `erc-button-press-button'."
(interactive "P\ne")
(save-excursion
@@ -416,7 +416,7 @@
;; XEmacs calls this via widget-button-press with a bunch of arguments
;; which we don't care about.
-(defun erc-button-press-button (&rest ignore)
+(defun erc-button-press-button (&rest _ignore)
"Check text at point for a callback function.
If the text at point has a `erc-callback' property,
call it with the value of the `erc-data' text property."
=== modified file 'lisp/erc/erc.el'
--- a/lisp/erc/erc.el 2013-09-14 23:33:19 +0000
+++ b/lisp/erc/erc.el 2013-09-19 02:21:31 +0000
@@ -1312,13 +1312,13 @@
(and (eq major-mode 'erc-mode)
(null (erc-default-target)))))
-(defun erc-open-server-buffer-p (&optional buffer) ;FIXME: `buffer' is ignored!
+(defun erc-open-server-buffer-p (&optional buffer)
"Return non-nil if argument BUFFER is an ERC server buffer that
has an open IRC process.
If BUFFER is nil, the current buffer is used."
- (and (erc-server-buffer-p)
- (erc-server-process-alive)))
+ (and (erc-server-buffer-p buffer)
+ (erc-server-process-alive buffer)))
(defun erc-query-buffer-p (&optional buffer)
"Return non-nil if BUFFER is an ERC query buffer.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] trunk r114380: Address some "unused lexical argument" warnings in erc,
Glenn Morris <=