emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] trunk r115542: * progmodes/compile.el (compile-goto-error)


From: Leo Liu
Subject: [Emacs-diffs] trunk r115542: * progmodes/compile.el (compile-goto-error): Do not push-mark.
Date: Mon, 16 Dec 2013 08:07:57 +0000
User-agent: Bazaar (2.6b2)

------------------------------------------------------------
revno: 115542
revision-id: address@hidden
parent: address@hidden
committer: Leo Liu <address@hidden>
branch nick: trunk
timestamp: Mon 2013-12-16 16:07:10 +0800
message:
  * progmodes/compile.el (compile-goto-error): Do not push-mark.
  Remove NOMSG arg and all uses changed.
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/progmodes/compile.el      compile.el-20091113204419-o5vbwnq5f7feedwu-126
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2013-12-16 02:24:08 +0000
+++ b/lisp/ChangeLog    2013-12-16 08:07:10 +0000
@@ -1,3 +1,8 @@
+2013-12-16  Leo Liu  <address@hidden>
+
+       * progmodes/compile.el (compile-goto-error): Do not push-mark.
+       Remove NOMSG arg and all uses changed.
+
 2013-12-16  Stefan Monnier  <address@hidden>
 
        * emulation/cua-rect.el (cua-rectangle-mark-mode): New minor mode.

=== modified file 'lisp/progmodes/compile.el'
--- a/lisp/progmodes/compile.el 2013-12-06 15:34:06 +0000
+++ b/lisp/progmodes/compile.el 2013-12-16 08:07:10 +0000
@@ -1004,7 +1004,7 @@
     (let ((win (get-buffer-window buffer 0)))
       (if win (set-window-point win pos)))
     (if compilation-auto-jump-to-first-error
-       (compile-goto-error nil t))))
+       (compile-goto-error))))
 
 ;; This function is the central driver, called when font-locking to gather
 ;; all information needed to later jump to corresponding source code.
@@ -2325,9 +2325,9 @@
 
 (defalias 'compile-mouse-goto-error 'compile-goto-error)
 
-(defun compile-goto-error (&optional event nomsg)
+(defun compile-goto-error (&optional event)
   "Visit the source for the error message at point.
-Use this command in a compilation log buffer.  Sets the mark at point there."
+Use this command in a compilation log buffer."
   (interactive (list last-input-event))
   (if event (posn-set-point (event-end event)))
   (or (compilation-buffer-p (current-buffer))
@@ -2336,7 +2336,6 @@
   (if (get-text-property (point) 'compilation-directory)
       (dired-other-window
        (car (get-text-property (point) 'compilation-directory)))
-    (push-mark nil nomsg)
     (setq compilation-current-error (point))
     (next-error-internal)))
 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]