[Emacs-diffs] trunk r117562: Correct ses-truncate-cell bug implied by setting ses.el in lexical binding: row and col had been erronously made unbound.

[Vincent Belaïche]

------------------------------------------------------------
revno: 117562
revision-id: address@hidden
parent: address@hidden
committer: Vincent Belaïche  <address@hidden>
branch nick: trunk
timestamp: Mon 2014-07-21 19:53:38 +0200
message:
  Correct ses-truncate-cell bug implied by setting ses.el in lexical binding: 
row and col had been erronously made unbound.
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/ses.el                    ses.el-20091113204419-o5vbwnq5f7feedwu-2447

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2014-07-21 06:03:08 +0000
+++ b/lisp/ChangeLog    2014-07-21 17:53:38 +0000
@@ -1,3 +1,9 @@
+2014-07-21  Vincent Belaïche  <address@hidden>
+
+       * ses.el (ses-truncate-cell): Use cl-progv instead of eval in
+       order to ensure that row and col are lexically bound inside the
+       evaluated sexp.
+
 2014-07-21  Glenn Morris  <address@hidden>
 
        * progmodes/hideif.el (hide-ifdef-mode-submap):

=== modified file 'lisp/ses.el'
--- a/lisp/ses.el       2014-06-15 04:10:40 +0000
+++ b/lisp/ses.el       2014-07-21 17:53:38 +0000
@@ -2252,8 +2252,10 @@
               (eq (ses-cell-value row (1+ col)) '*skip*))
       ;; This cell has spill-over.  We'll momentarily pretend the following 
cell
       ;; has a `t' in it.
-      (eval `(let ((,(ses-cell-symbol row (1+ col)) t))
-              (ses-print-cell row col)))
+      (cl-progv
+         (list (ses-cell-symbol row (1+ col)))
+         '(t)
+              (ses-print-cell row col))
       ;; Now remove the *skip*.  ses-print-cell is always nil here.
       (ses-set-cell row (1+ col) 'value nil)
       (1value (ses-print-cell row (1+ col))))))