emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-24 r117605: * list/emulation/viper: Add some FIXME c


From: Stefan Monnier
Subject: [Emacs-diffs] emacs-24 r117605: * list/emulation/viper: Add some FIXME comments.
Date: Mon, 20 Oct 2014 22:35:46 +0000
User-agent: Bazaar (2.6b2)

------------------------------------------------------------
revno: 117605
revision-id: address@hidden
parent: address@hidden
committer: Stefan Monnier <address@hidden>
branch nick: emacs-24
timestamp: Mon 2014-10-20 18:35:43 -0400
message:
  * list/emulation/viper: Add some FIXME comments.
modified:
  lisp/emulation/viper-util.el   
viperutil.el-20091113204419-o5vbwnq5f7feedwu-840
  lisp/emulation/viper.el        viper.el-20091113204419-o5vbwnq5f7feedwu-841
=== modified file 'lisp/emulation/viper-util.el'
--- a/lisp/emulation/viper-util.el      2014-01-01 07:43:34 +0000
+++ b/lisp/emulation/viper-util.el      2014-10-20 22:35:43 +0000
@@ -984,7 +984,7 @@
 ;; macros, since it enables certain macros to be shared between X and TTY modes
 ;; by correctly mapping key sequences for Left/Right/... (on an ascii
 ;; terminal) into logical keys left, right, etc.
-(defun viper-read-key ()
+(defun viper-read-key () ;; FIXME: Use `read-key'?
   (let ((overriding-local-map viper-overriding-map)
        (inhibit-quit t)
        help-char key)

=== modified file 'lisp/emulation/viper.el'
--- a/lisp/emulation/viper.el   2014-06-29 02:33:50 +0000
+++ b/lisp/emulation/viper.el   2014-10-20 22:35:43 +0000
@@ -531,6 +531,7 @@
        (if viper-mode
            ()
          (setq viper-mode t)
+          ;; FIXME: Don't reload!
          (load-library "viper"))
 
        (if viper-first-time ; Important check.  Prevents mix-up of startup
@@ -887,6 +888,7 @@
   ;; When viper-mode is executed in such a case, it will set the major mode
   ;; back to fundamental-mode.
   (if (eq (default-value 'major-mode) 'fundamental-mode)
+      ;; FIXME: We should use after-change-major-mode-hook instead!
       (setq-default major-mode 'viper-mode))
 
   (viper-setup-ESC-to-escape t)
@@ -936,6 +938,7 @@
 
   (defadvice self-insert-command (around viper-self-insert-ad activate)
     "Ignore all self-inserting keys in the vi-state."
+    ;; FIXME: Use remapping?
     (if (and (eq viper-current-state 'vi-state)
             ;; Do not use called-interactively-p here. XEmacs does not have it
             ;; and interactive-p is just fine.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]