[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] emacs-24 r117630: Fix bug #18874 with rgrep not obeying gr
From: |
Eli Zaretskii |
Subject: |
[Emacs-diffs] emacs-24 r117630: Fix bug #18874 with rgrep not obeying grep-scroll-output. |
Date: |
Wed, 29 Oct 2014 15:18:14 +0000 |
User-agent: |
Bazaar (2.6b2) |
------------------------------------------------------------
revno: 117630
revision-id: address@hidden
parent: address@hidden
fixes bug: http://debbugs.gnu.org/18874
committer: Eli Zaretskii <address@hidden>
branch nick: emacs-24
timestamp: Wed 2014-10-29 17:17:18 +0200
message:
Fix bug #18874 with rgrep not obeying grep-scroll-output.
lisp/progmodes/compile.el (compilation-start): If
compilation-scroll-output is non-nil, don't force window-start of
the compilation buffer to be at beginning of buffer.
modified:
lisp/ChangeLog changelog-20091113204419-o5vbwnq5f7feedwu-1432
lisp/progmodes/compile.el compile.el-20091113204419-o5vbwnq5f7feedwu-126
=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog 2014-10-23 19:17:00 +0000
+++ b/lisp/ChangeLog 2014-10-29 15:17:18 +0000
@@ -1,3 +1,9 @@
+2014-10-29 Eli Zaretskii <address@hidden>
+
+ * progmodes/compile.el (compilation-start): If
+ compilation-scroll-output is non-nil, don't force window-start of
+ the compilation buffer to be at beginning of buffer. (Bug#18874)
+
2014-10-23 Tassilo Horn <address@hidden>
* doc-view.el (doc-view-open-text): View the document's plain text
=== modified file 'lisp/progmodes/compile.el'
--- a/lisp/progmodes/compile.el 2014-05-09 06:42:39 +0000
+++ b/lisp/progmodes/compile.el 2014-10-29 15:17:18 +0000
@@ -1651,7 +1651,16 @@
(list command mode name-function highlight-regexp))
(set (make-local-variable 'revert-buffer-function)
'compilation-revert-buffer)
- (and outwin (set-window-start outwin (point-min)))
+ (and outwin
+ ;; Forcing the window-start overrides the usual redisplay
+ ;; feature of bringing point into view, so setting the
+ ;; window-start to top of the buffer risks losing the
+ ;; effect of moving point to EOB below, per
+ ;; compilation-scroll-output, if the command is long
+ ;; enough to push point outside of the window. This
+ ;; could happen, e.g., in `rgrep'.
+ (not compilation-scroll-output)
+ (set-window-start outwin (point-min)))
;; Position point as the user will see it.
(let ((desired-visible-point
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] emacs-24 r117630: Fix bug #18874 with rgrep not obeying grep-scroll-output.,
Eli Zaretskii <=