[Emacs-diffs] master 456696a: Avoid having eww unexpectedly open external browsers

[Lars Ingebrigtsen]

branch: master
commit 456696a838dfef73364ca025a210d2198fd8390d
Author: Lars Ingebrigtsen <address@hidden>
Commit: Lars Ingebrigtsen <address@hidden>

    Avoid having eww unexpectedly open external browsers
    
    * lisp/net/eww.el (eww-render): Instead of opening unsupported
    content types like audio/mpeg directly in an external browser
    (which can be very confusing especially when something
    redirects to a file like that), just display a simple
    interstitial that people can choose to click on or not
    (bug#22671).
---
 lisp/net/eww.el |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 3e5d446..172044a 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -364,7 +364,14 @@ Currently this means either text/html or 
application/xhtml+xml."
            ((and eww-use-external-browser-for-content-type
                  (string-match-p eww-use-external-browser-for-content-type
                                  (car content-type)))
-            (eww-browse-with-external-browser url))
+            (erase-buffer)
+            (insert "<title>Unsupported content type</title>")
+            (insert (format "<h1>Content-type %s is unsupported</h1>"
+                            (car content-type)))
+            (insert (format "<a href=%S>Direct link to the document</a>"
+                            url))
+            (goto-char (point-min))
+           (eww-display-html charset url nil point buffer encode))
           ((eww-html-p (car content-type))
            (eww-display-html charset url nil point buffer encode))
           ((equal (car content-type) "application/pdf")