[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] scratch/merge-cedet-tests 9b72617 282/316: Don't set :file
From: |
Edward John Steere |
Subject: |
[Emacs-diffs] scratch/merge-cedet-tests 9b72617 282/316: Don't set :filename if it's already set |
Date: |
Sat, 28 Jan 2017 09:10:11 +0000 (UTC) |
branch: scratch/merge-cedet-tests
commit 9b72617d81a87cfbd30c2cf2f1abb34e3b5139f0
Author: Darren Hoo <address@hidden>
Commit: Edward John Steere <address@hidden>
Don't set :filename if it's already set
* test/manual/cedet/cit-externaldb.el:
(semanticdb-strip-find-results): Check if there already is a
:filename attribute set, so that file information from GNU Global
will not be lost.
* tests/cit-externaldb.el: New test for :filename property. Make
doc-string and comments generic, since this is not specific to GNU
global.
---
test/manual/cedet/cit-externaldb.el | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/test/manual/cedet/cit-externaldb.el
b/test/manual/cedet/cit-externaldb.el
index 89897c4..cbc3504 100644
--- a/test/manual/cedet/cit-externaldb.el
+++ b/test/manual/cedet/cit-externaldb.el
@@ -105,7 +105,7 @@
semanticdbenablefcn
semanticdbclass
cleanupfiles)
- "Test GNU Global tooling integration if it is available."
+ "Test external database tooling integration if it is available."
(let ((bufftokill (find-file (cit-file "Project.ede"))))
;; 1) Create
@@ -113,7 +113,7 @@
;; database.
(funcall createfcn default-directory)
- ;; 2) force ede's find file to use gnu global
+ ;; 2) force ede's find file to use external tool
(require 'ede-locate)
(let* ((ede-locate-setup-options (list edelocatesym))
(base default-directory)
@@ -140,7 +140,7 @@
;; After removing the old locate system, restore the old one.
(ede-enable-locate-on-project)
- ;; 3) Look up tags with a GNU Global database
+ ;; 3) Look up tags with a external database
(if semanticdbenablefcn
(save-excursion
(let ((killme (find-file (cit-file "src/main.cpp"))))
@@ -158,6 +158,11 @@
symrefsym
(semanticdb-find-result-length res)))
+ (dolist (tag (semanticdb-strip-find-results res 'name))
+ (if (not (semantic--tag-get-property tag :filename))
+ (error "Tag %s does not point to a specific file."
+ (semantic-tag-name tag))))
+
(kill-buffer killme))))
;; else, message
(message "Skipping %s database test : Nothing to test." symrefsym))
@@ -170,7 +175,7 @@
;; Do the tests again.
(cit-symref-quick-find-test)
- ;; Delete the GTAGS and other files.
+ ;; Delete the files created by external tool.
(dolist (F cleanupfiles)
(when (file-exists-p F)
(delete-file F)))
- [Emacs-diffs] scratch/merge-cedet-tests 816e083 151/316: (ede-detect-utest-project-list): Add test for generic VC type project. (ede-detect-utest): Add fake autoloader for VC. (ede-detect-utest-generic-vc-p): New., (continued)
- [Emacs-diffs] scratch/merge-cedet-tests 816e083 151/316: (ede-detect-utest-project-list): Add test for generic VC type project. (ede-detect-utest): Add fake autoloader for VC. (ede-detect-utest-generic-vc-p): New., Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests e9c9716 279/316: Fixes for external db tests, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests e0d3d7b 303/316: New tests., Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests ec14f1c 315/316: Move tests in cedet/semantic, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests c2f09c4 182/316: (cedet-integ-test-proj): Add cit-remove-and-do-shared-lib., Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 63dbe0c 276/316: Move tests in cedet/semantic, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 9480090 261/316: Test updating the project version, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests e78d9b8 201/316: Fix merge error in unit tests., Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 8989dc6 313/316: New Tests for ede-java-root-project type., Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests c89acc2 305/316: Add test code for use with sources in globalref, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 9b72617 282/316: Don't set :filename if it's already set,
Edward John Steere <=
- [Emacs-diffs] scratch/merge-cedet-tests 2448a55 268/316: Fix unit testing for several tests and do better error checking., Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 6adc6be 266/316: Move tests in cedet/semantic, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 3cb2319 243/316: Added code for test tags, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 101da66 306/316: Don't scan other files because Util.cc is already in a buffer, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 3cc63e2 316/316: Remove tests and redundant resources not destined for merge, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests d8c1209 234/316: CPP integration support. Core bits copied originally from cedet-integ-test.el, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 82586cd 209/316: eieio: Move to obsolete and use the one that ships with Emacs, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests e54714f 227/316: Add header comments and provide., Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 4730d02 197/316: Refactor tests, Edward John Steere, 2017/01/28
- [Emacs-diffs] scratch/merge-cedet-tests 82a840d 244/316: Use ldflags and libs for in project libraries, Edward John Steere, 2017/01/28