emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 6a151cf: Don't pass the value of point to 'push-mar


From: Eli Zaretskii
Subject: [Emacs-diffs] master 6a151cf: Don't pass the value of point to 'push-mark', as that's the default.
Date: Fri, 28 Apr 2017 04:27:19 -0400 (EDT)

branch: master
commit 6a151cf8d5202ddde5d190dad542dadc26b66b93
Author: Bartosz Duszel <address@hidden>
Commit: Eli Zaretskii <address@hidden>

    Don't pass the value of point to 'push-mark', as that's the default.
    
    * lisp/textmodes/bib-mode.el (mark-bib):
    * lisp/simple.el (mark-whole-buffer, yank):
    * lisp/ses.el (ses--advice-yank, ses-mark-row, ses-mark-column):
    * lisp/progmodes/xscheme.el (xscheme-yank):
    * lisp/progmodes/verilog-mode.el (verilog-mark-defun):
    * lisp/progmodes/perl-mode.el (perl-mark-function):
    * lisp/progmodes/pascal.el (pascal-mark-defun):
    * lisp/progmodes/meta-mode.el (meta-mark-defun):
    * lisp/progmodes/icon.el (mark-icon-function):
    * lisp/progmodes/cc-cmds.el (c-mark-function):
    * lisp/obsolete/vip.el (ex-goto):
    * lisp/obsolete/vi.el (vi-put-before):
    * lisp/mouse.el (mouse-yank-primary):
    * lisp/menu-bar.el (menu-bar-select-yank):
    * lisp/mail/sendmail.el (mail-yank-original):
    * lisp/hexl.el (hexl-beginning-of-buffer, hexl-end-of-buffer):
    * lisp/emulation/viper-cmd.el (viper-mark-beginning-of-buffer)
    (viper-mark-end-of-buffer):
    * lisp/cedet/semantic/senator.el (senator-mark-defun):
    * lisp/allout.el (allout-mark-topic): Remove unnecessary argument
    `(point)' from calls to `push-mark'.  (Bug#25565)
---
 lisp/allout.el                 | 2 +-
 lisp/cedet/semantic/senator.el | 2 +-
 lisp/emulation/viper-cmd.el    | 4 ++--
 lisp/hexl.el                   | 4 ++--
 lisp/mail/sendmail.el          | 2 +-
 lisp/menu-bar.el               | 2 +-
 lisp/mouse.el                  | 2 +-
 lisp/obsolete/vi.el            | 2 +-
 lisp/obsolete/vip.el           | 2 +-
 lisp/progmodes/cc-cmds.el      | 2 +-
 lisp/progmodes/icon.el         | 4 ++--
 lisp/progmodes/meta-mode.el    | 2 +-
 lisp/progmodes/pascal.el       | 4 ++--
 lisp/progmodes/perl-mode.el    | 4 ++--
 lisp/progmodes/verilog-mode.el | 4 ++--
 lisp/progmodes/xscheme.el      | 2 +-
 lisp/ses.el                    | 6 +++---
 lisp/simple.el                 | 4 ++--
 lisp/textmodes/bib-mode.el     | 2 +-
 19 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/lisp/allout.el b/lisp/allout.el
index e837f83..529de85 100644
--- a/lisp/allout.el
+++ b/lisp/allout.el
@@ -6503,7 +6503,7 @@ not its value."
   (let ((inhibit-field-text-motion t))
     (beginning-of-line))
   (allout-goto-prefix-doublechecked)
-  (push-mark (point))
+  (push-mark)
   (allout-end-of-current-subtree)
   (exchange-point-and-mark))
 ;;;_  : UI:
diff --git a/lisp/cedet/semantic/senator.el b/lisp/cedet/semantic/senator.el
index 407bb05..f1918c4 100644
--- a/lisp/cedet/semantic/senator.el
+++ b/lisp/cedet/semantic/senator.el
@@ -659,7 +659,7 @@ Use semantic tags to navigate."
         (end    (progn (senator-end-of-defun) (point)))
         (start  (progn (senator-beginning-of-defun) (point))))
     (goto-char origin)
-    (push-mark (point))
+    (push-mark)
     (goto-char end) ;; end-of-defun
     (push-mark (point) nil t)
     (goto-char start) ;; beginning-of-defun
diff --git a/lisp/emulation/viper-cmd.el b/lisp/emulation/viper-cmd.el
index aa31fac..831b9c1 100644
--- a/lisp/emulation/viper-cmd.el
+++ b/lisp/emulation/viper-cmd.el
@@ -4346,7 +4346,7 @@ and regexp replace."
 (defun viper-mark-beginning-of-buffer ()
   "Mark beginning of buffer."
   (interactive)
-  (push-mark (point))
+  (push-mark)
   (goto-char (point-min))
   (exchange-point-and-mark)
   (message "Mark set at the beginning of buffer"))
@@ -4354,7 +4354,7 @@ and regexp replace."
 (defun viper-mark-end-of-buffer ()
   "Mark end of buffer."
   (interactive)
-  (push-mark (point))
+  (push-mark)
   (goto-char (point-max))
   (exchange-point-and-mark)
   (message "Mark set at the end of buffer"))
diff --git a/lisp/hexl.el b/lisp/hexl.el
index b5e9c1f..0a598b2 100644
--- a/lisp/hexl.el
+++ b/lisp/hexl.el
@@ -730,13 +730,13 @@ If there is no byte at the target address move to the 
last byte in that line."
 Leaves `hexl-mark' at previous position.
 With prefix arg N, puts point N bytes of the way from the true beginning."
   (interactive "p")
-  (push-mark (point))
+  (push-mark)
   (hexl-goto-address (+ 0 (1- arg))))
 
 (defun hexl-end-of-buffer (arg)
   "Go to `hexl-max-address' minus ARG."
   (interactive "p")
-  (push-mark (point))
+  (push-mark)
   (hexl-goto-address (- hexl-max-address (1- arg))))
 
 (defun hexl-beginning-of-line ()
diff --git a/lisp/mail/sendmail.el b/lisp/mail/sendmail.el
index 42b688f..12d69aa 100644
--- a/lisp/mail/sendmail.el
+++ b/lisp/mail/sendmail.el
@@ -1677,7 +1677,7 @@ and don't delete any header fields."
              ;; Call yank function, and set the mark if it doesn't.
              (apply (car original) (cdr original))
              (if (eq omark (mark t))
-                 (push-mark (point))))
+                 (push-mark)))
          ;; If the original message is in another window in the same
          ;; frame, delete that window to save space.
          (delete-windows-on original t)
diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index 719173c..6befa6d 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -1974,7 +1974,7 @@ otherwise it could decide to silently do nothing."
   "Insert the stretch of previously-killed text selected from menu.
 The menu shows all the killed text sequences stored in `kill-ring'."
   (interactive "*")
-  (push-mark (point))
+  (push-mark)
   (insert last-command-event))
 
 
diff --git a/lisp/mouse.el b/lisp/mouse.el
index 0f1d446..0520fd1 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -1135,7 +1135,7 @@ regardless of where you click."
       (deactivate-mark)))
   (or mouse-yank-at-point (mouse-set-point click))
   (let ((primary (gui-get-primary-selection)))
-    (push-mark (point))
+    (push-mark)
     (insert-for-yank primary)))
 
 (defun mouse-kill-ring-save (click)
diff --git a/lisp/obsolete/vi.el b/lisp/obsolete/vi.el
index 081b229..5b611aa 100644
--- a/lisp/obsolete/vi.el
+++ b/lisp/obsolete/vi.el
@@ -1128,7 +1128,7 @@ text as lines.  If the optional after-p is given, put 
after/below the cursor."
              (progn (forward-line 1) (beginning-of-line))
            (beginning-of-line))
        (if after-p (forward-char 1)))
-      (push-mark (point))
+      (push-mark)
       (insert put-text)
       (exchange-point-and-mark)
 ;;    (back-to-indentation)      ; this is not allowed if we allow yank-pop
diff --git a/lisp/obsolete/vip.el b/lisp/obsolete/vip.el
index ca0bfe7..4d70d6a 100644
--- a/lisp/obsolete/vip.el
+++ b/lisp/obsolete/vip.el
@@ -2596,7 +2596,7 @@ a token has type \(command, address, end-mark\) and 
value."
   "ex goto command"
   (if (null ex-addresses)
       (setq ex-addresses (cons (point) nil)))
-  (push-mark (point))
+  (push-mark)
   (goto-char (car ex-addresses))
   (beginning-of-line))
 
diff --git a/lisp/progmodes/cc-cmds.el b/lisp/progmodes/cc-cmds.el
index 561e676..a5ddcb4 100644
--- a/lisp/progmodes/cc-cmds.el
+++ b/lisp/progmodes/cc-cmds.el
@@ -2041,7 +2041,7 @@ function does not require the declaration to contain a 
brace block."
             (push-mark-p (and (eq this-command 'c-mark-function)
                               (not extend-region-p)
                               (not (c-region-is-active-p)))))
-       (if push-mark-p (push-mark (point)))
+       (if push-mark-p (push-mark))
        (if extend-region-p
            (progn
              (exchange-point-and-mark)
diff --git a/lisp/progmodes/icon.el b/lisp/progmodes/icon.el
index 0c699a0..92a89fe 100644
--- a/lisp/progmodes/icon.el
+++ b/lisp/progmodes/icon.el
@@ -459,9 +459,9 @@ Returns nil if line starts inside a string, t if in a 
comment."
 (defun mark-icon-function ()
   "Put mark at end of Icon function, point at beginning."
   (interactive)
-  (push-mark (point))
+  (push-mark)
   (end-of-icon-defun)
-  (push-mark (point))
+  (push-mark)
   (beginning-of-line 0)
   (beginning-of-icon-defun))
 
diff --git a/lisp/progmodes/meta-mode.el b/lisp/progmodes/meta-mode.el
index 3db3b8a..3377226 100644
--- a/lisp/progmodes/meta-mode.el
+++ b/lisp/progmodes/meta-mode.el
@@ -780,7 +780,7 @@ The environment indented is the one that contains point or 
follows point."
   "Put mark at end of the environment, point at the beginning.
 The environment marked is the one that contains point or follows point."
   (interactive)
-  (push-mark (point))
+  (push-mark)
   (meta-end-of-defun)
   (push-mark (point) nil t)
   (meta-beginning-of-defun))
diff --git a/lisp/progmodes/pascal.el b/lisp/progmodes/pascal.el
index bf49ba4..a7d0624 100644
--- a/lisp/progmodes/pascal.el
+++ b/lisp/progmodes/pascal.el
@@ -507,9 +507,9 @@ See also the user variables `pascal-type-keywords', 
`pascal-start-keywords' and
   "Mark the current Pascal function (or procedure).
 This puts the mark at the end, and point at the beginning."
   (interactive)
-  (push-mark (point))
+  (push-mark)
   (pascal-end-of-defun)
-  (push-mark (point))
+  (push-mark)
   (pascal-beg-of-defun)
   (when (featurep 'xemacs)
     (zmacs-activate-region)))
diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el
index b75f32e..3def37a 100644
--- a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -1104,9 +1104,9 @@ With argument, repeat that many times; negative args move 
backward."
 (defun perl-mark-function ()
   "Put mark at end of Perl function, point at beginning."
   (interactive)
-  (push-mark (point))
+  (push-mark)
   (perl-end-of-function)
-  (push-mark (point))
+  (push-mark)
   (perl-beginning-of-function)
   (backward-paragraph))
 
diff --git a/lisp/progmodes/verilog-mode.el b/lisp/progmodes/verilog-mode.el
index 48ee555..9f3bad1 100644
--- a/lisp/progmodes/verilog-mode.el
+++ b/lisp/progmodes/verilog-mode.el
@@ -4212,9 +4212,9 @@ This puts the mark at the end, and point at the 
beginning."
   (interactive)
   (if (featurep 'xemacs)
       (progn
-       (push-mark (point))
+       (push-mark)
        (verilog-end-of-defun)
-       (push-mark (point))
+       (push-mark)
        (verilog-beg-of-defun)
        (if (fboundp 'zmacs-activate-region)
            (zmacs-activate-region)))
diff --git a/lisp/progmodes/xscheme.el b/lisp/progmodes/xscheme.el
index 4502c6d..bdfe30a 100644
--- a/lisp/progmodes/xscheme.el
+++ b/lisp/progmodes/xscheme.el
@@ -580,7 +580,7 @@ See also the commands \\[xscheme-yank-pop] and 
\\[xscheme-yank-push]."
   (xscheme-rotate-yank-pointer (if (listp arg) 0
                                 (if (eq arg '-) -1
                                   (1- arg))))
-  (push-mark (point))
+  (push-mark)
   (insert (car xscheme-expressions-ring-yank-pointer))
   (if (consp arg)
       (exchange-point-and-mark)))
diff --git a/lisp/ses.el b/lisp/ses.el
index 0fcd50c..fd7174d 100644
--- a/lisp/ses.el
+++ b/lisp/ses.el
@@ -3028,7 +3028,7 @@ as symbols."
                (eq (get-text-property (point) 'keymap) 'ses-mode-print-map)))
       (apply yank-fun arg args) ; Normal non-SES yank.
     (ses-check-curcell 'end)
-    (push-mark (point))
+    (push-mark)
     (let ((text (current-kill (cond
                               ((listp arg)  0)
                               ((eq arg '-)  -1)
@@ -3295,7 +3295,7 @@ The top row is row 1.  Selecting row 0 displays the 
default header row."
   (interactive)
   (ses-check-curcell 'range)
   (let ((row (car (ses-sym-rowcol (or (car-safe ses--curcell) ses--curcell)))))
-    (push-mark (point))
+    (push-mark)
     (ses-goto-print (1+ row) 0)
     (push-mark (point) nil t)
     (ses-goto-print row 0)))
@@ -3306,7 +3306,7 @@ The top row is row 1.  Selecting row 0 displays the 
default header row."
   (ses-check-curcell 'range)
   (let ((col (cdr (ses-sym-rowcol (or (car-safe ses--curcell) ses--curcell))))
        (row 0))
-    (push-mark (point))
+    (push-mark)
     (ses-goto-print (1- ses--numrows) col)
     (forward-char 1)
     (push-mark (point) nil t)
diff --git a/lisp/simple.el b/lisp/simple.el
index a58164a..edc822e 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1104,7 +1104,7 @@ it is usually a mistake for a Lisp function to use any 
subroutine
 that uses or sets the mark."
   (declare (interactive-only t))
   (interactive)
-  (push-mark (point))
+  (push-mark)
   (push-mark (point-max) nil t)
   ;; This is really `point-min' in most cases, but if we're in the
   ;; minibuffer, this is at the end of the prompt.
@@ -4860,7 +4860,7 @@ See also the command `yank-pop' (\\[yank-pop])."
   ;; If we don't get all the way thru, make last-command indicate that
   ;; for the following command.
   (setq this-command t)
-  (push-mark (point))
+  (push-mark)
   (insert-for-yank (current-kill (cond
                                  ((listp arg) 0)
                                  ((eq arg '-) -2)
diff --git a/lisp/textmodes/bib-mode.el b/lisp/textmodes/bib-mode.el
index 74d2144..2f3c17b 100644
--- a/lisp/textmodes/bib-mode.el
+++ b/lisp/textmodes/bib-mode.el
@@ -181,7 +181,7 @@ with the cdr.")
    (re-search-backward "^ *$" nil 2)
    (re-search-forward "^%")
    (beginning-of-line nil)
-   (push-mark (point))
+   (push-mark)
    (re-search-forward "^ *$" nil 2)
    (forward-line 1)
    (beginning-of-line nil))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]