emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 70bb510: Prefer file-name-quote to concat "/:"


From: Paul Eggert
Subject: [Emacs-diffs] master 70bb510: Prefer file-name-quote to concat "/:"
Date: Tue, 29 Aug 2017 22:18:43 -0400 (EDT)

branch: master
commit 70bb510a7eb1a3010cfa034884b7e5ab2063ece3
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

    Prefer file-name-quote to concat "/:"
    
    Suggested by Michael Albinus (Bug#28264#13).
    * lisp/files.el (files--splice-dirname-file): Use file-name-quote
    rather than attempting to do it by hand.
---
 lisp/files.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lisp/files.el b/lisp/files.el
index 5f55aa7..7754be2 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -1156,16 +1156,16 @@ names beginning with `~'."
 (defun files--splice-dirname-file (dirname file)
   "Splice DIRNAME to FILE like the operating system would.
 If FILENAME is relative, return DIRNAME concatenated to FILE.
-Otherwise return FILE, quoted with `/:' if DIRNAME and FILE have
+Otherwise return FILE, quoted as needed if DIRNAME and FILE have
 different handlers; although this quoting is dubious if DIRNAME
-is remote, it is not clear what would be better.  This function
+is magic, it is not clear what would be better.  This function
 differs from `expand-file-name' in that DIRNAME must be a
 directory name and leading `~' and `/:' are not special in FILE."
   (if (files--name-absolute-system-p file)
       (if (eq (find-file-name-handler dirname 'file-symlink-p)
              (find-file-name-handler file 'file-symlink-p))
          file
-       (concat "/:" file))
+       (file-name-quote file))
     (concat dirname file)))
 
 (defun file-truename (filename &optional counter prev-dirs)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]