emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-26 f172894: Exit macro definition on undefined keys


From: Eli Zaretskii
Subject: [Emacs-diffs] emacs-26 f172894: Exit macro definition on undefined keys
Date: Sat, 30 Sep 2017 09:48:40 -0400 (EDT)

branch: emacs-26
commit f17289459527da254d02e516e944c89d3c505377
Author: Allen Li <address@hidden>
Commit: Eli Zaretskii <address@hidden>

    Exit macro definition on undefined keys
    
    * lisp/subr.el (undefined): Error out of kmacro definition, if any.
    (Bug#28008)
    
    Copyright-paperwork-exempt: yes
---
 lisp/subr.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/subr.el b/lisp/subr.el
index cf15ec2..64479a4 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -785,8 +785,9 @@ This is the same format used for saving keyboard macros (see
   "Beep to tell the user this binding is undefined."
   (interactive)
   (ding)
-  (message "%s is undefined" (key-description (this-single-command-keys)))
-  (setq defining-kbd-macro nil)
+  (if defining-kbd-macro
+      (error "%s is undefined" (key-description (this-single-command-keys)))
+    (message "%s is undefined" (key-description (this-single-command-keys))))
   (force-mode-line-update)
   ;; If this is a down-mouse event, don't reset prefix-arg;
   ;; pass it to the command run by the up event.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]