[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master 8048caa 2/2: Make compiler warn about use of obsole
From: |
Glenn Morris |
Subject: |
[Emacs-diffs] master 8048caa 2/2: Make compiler warn about use of obsolete hooks |
Date: |
Mon, 12 Mar 2018 14:29:17 -0400 (EDT) |
branch: master
commit 8048caab1d4125991b475be0ff8052f319221174
Author: Glenn Morris <address@hidden>
Commit: Glenn Morris <address@hidden>
Make compiler warn about use of obsolete hooks
* lisp/emacs-lisp/bytecomp.el (byte-compile-form):
Warn about using obsolete hooks.
---
lisp/emacs-lisp/bytecomp.el | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 2a986f6..b3ea930 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -3119,6 +3119,11 @@ for symbols generated by the byte compiler itself."
(when (assq var byte-compile-lexical-variables)
(byte-compile-report-error
(format-message "%s cannot use lexical var `%s'" fn var))))))
+ ;; Warn about using obsolete hooks.
+ (if (memq fn '(add-hook remove-hook))
+ (let ((hook (car-safe (cdr form))))
+ (if (eq (car-safe hook) 'quote)
+ (byte-compile-check-variable (cadr hook) nil))))
(when (and (byte-compile-warning-enabled-p 'suspicious)
(macroexp--const-symbol-p fn))
(byte-compile-warn "`%s' called as a function" fn))