[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] feature/gnus-select 280de6e 061/218: Make compiler warn ab
From: |
Andrew G Cohen |
Subject: |
[Emacs-diffs] feature/gnus-select 280de6e 061/218: Make compiler warn about use of obsolete hooks |
Date: |
Fri, 14 Dec 2018 03:34:58 -0500 (EST) |
branch: feature/gnus-select
commit 280de6e628300196a533c018e69dae740bf2f8f6
Author: Glenn Morris <address@hidden>
Commit: Andrew G Cohen <address@hidden>
Make compiler warn about use of obsolete hooks
* lisp/emacs-lisp/bytecomp.el (byte-compile-form):
Warn about using obsolete hooks.
---
lisp/emacs-lisp/bytecomp.el | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 2a986f6..b3ea930 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -3119,6 +3119,11 @@ for symbols generated by the byte compiler itself."
(when (assq var byte-compile-lexical-variables)
(byte-compile-report-error
(format-message "%s cannot use lexical var `%s'" fn var))))))
+ ;; Warn about using obsolete hooks.
+ (if (memq fn '(add-hook remove-hook))
+ (let ((hook (car-safe (cdr form))))
+ (if (eq (car-safe hook) 'quote)
+ (byte-compile-check-variable (cadr hook) nil))))
(when (and (byte-compile-warning-enabled-p 'suspicious)
(macroexp--const-symbol-p fn))
(byte-compile-warn "`%s' called as a function" fn))
- [Emacs-diffs] feature/gnus-select aa2ebec 141/218: Extend Tramp's UTF8 tests, (continued)
- [Emacs-diffs] feature/gnus-select aa2ebec 141/218: Extend Tramp's UTF8 tests, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select b2b31ae 134/218: ; Spelling fix, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 59a41b8 107/218: Optimize tramp-tests.el, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select d74261f 158/218: * doc/lispref/windows.texi (Selecting Windows): Fix a typo., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 367ff81 120/218: More proofreading of the Emacs manual, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select e2b6627 049/218: Improve and make use of 'image--get-image', Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select c8d9b5d 051/218: Unify documentation on 'save-some-buffers', Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 958e0ff 037/218: Allow underline position variables be buffer-local, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 17d92f5 031/218: Quieten compilation of some test/lisp files, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 1731947 053/218: Document 'transpose-sentences' and 'transpose-paragraphs', Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 280de6e 061/218: Make compiler warn about use of obsolete hooks,
Andrew G Cohen <=
- [Emacs-diffs] feature/gnus-select 8c08be2 058/218: * lisp/minibuffer.el (completion-cycle-threshold): Doc fix., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select f82d6e9 059/218: Revert overenthusiastic procfs fixup, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select ad8d136 054/218: Allow toggling Grep command abbreviation, and rename related symbols, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 3c8297e 066/218: ; tiny NEWS fix, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select aa527be 071/218: Replace an obsolete alias in tpu-mapper, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 16cfb9a 074/218: * lisp/progmodes/ada-mode.el (ada-clean-buffer-before-saving): Doc fix., Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 29b7170 073/218: Doc fixes re obsolete items, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select 77bf8e0 077/218: Fix line-wrapping for term.el (Bug#30775), Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select e274f0b 075/218: Fix some allout.el aliases, Andrew G Cohen, 2018/12/14
- [Emacs-diffs] feature/gnus-select c6e52fa 088/218: Improve robustness in tramp-sh.el, Andrew G Cohen, 2018/12/14