[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/dash cd137e0 310/426: `-slice` should not fill the retu
From: |
Phillip Lord |
Subject: |
[elpa] externals/dash cd137e0 310/426: `-slice` should not fill the returned list with nils if to > length |
Date: |
Tue, 04 Aug 2015 19:38:30 +0000 |
branch: externals/dash
commit cd137e0d50c572246ea513499dd13d14690c1792
Author: Matus Goljer <address@hidden>
Commit: Matus Goljer <address@hidden>
`-slice` should not fill the returned list with nils if to > length
---
dash.el | 11 ++++-------
dev/examples.el | 5 ++++-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/dash.el b/dash.el
index 41aea86..7c1a772 100644
--- a/dash.el
+++ b/dash.el
@@ -436,8 +436,7 @@ Returns `nil` both if all items match the predicate, and if
none of the items ma
"Return copy of LIST, starting from index FROM to index TO.
FROM or TO may be negative."
(let ((length (length list))
- (new-list nil)
- (index 0))
+ (new-list nil))
;; to defaults to the end of the list
(setq to (or to length))
;; handle negative indices
@@ -447,11 +446,9 @@ FROM or TO may be negative."
(setq to (mod to length)))
;; iterate through the list, keeping the elements we want
- (while (< index to)
- (when (>= index from)
- (!cons (car list) new-list))
- (!cdr list)
- (setq index (1+ index)))
+ (--each-while list (< it-index to)
+ (when (>= it-index from)
+ (push it new-list)))
(nreverse new-list)))
(defun -take (n list)
diff --git a/dev/examples.el b/dev/examples.el
index 4de5882..28fceb6 100644
--- a/dev/examples.el
+++ b/dev/examples.el
@@ -70,7 +70,10 @@
(defexamples -slice
(-slice '(1 2 3 4 5) 1) => '(2 3 4 5)
(-slice '(1 2 3 4 5) 0 3) => '(1 2 3)
- (-slice '(1 2 3 4 5) 1 -1) => '(2 3 4))
+ (-slice '(1 2 3 4 5) 1 -1) => '(2 3 4)
+ (-slice '(1 2 3 4 5) 0 10) => '(1 2 3 4 5) ;; "to > length" should not
fill in nils!
+ (-slice '(1 2 3 4 5) -3) => '(3 4 5)
+ (-slice '(1 2 3 4 5) -3 -1) => '(3 4))
(defexamples -take
(-take 3 '(1 2 3 4 5)) => '(1 2 3)
- [elpa] externals/dash 9e1a667 360/426: Do not map nodes on conses (be consistent with tree map), (continued)
- [elpa] externals/dash 9e1a667 360/426: Do not map nodes on conses (be consistent with tree map), Phillip Lord, 2015/08/04
- [elpa] externals/dash 7185db8 311/426: [Issue #83] Add `step` to `-slice`, Phillip Lord, 2015/08/04
- [elpa] externals/dash 2b69c14 411/426: Add dash.info and dash.texi to repo, Phillip Lord, 2015/08/04
- [elpa] externals/dash c61fc34 417/426: Add -remove-first/last, -map-first/last, -replace-first/last, Phillip Lord, 2015/08/04
- [elpa] externals/dash fb51f8f 304/426: Merge pull request #88 from steventlamb/topic/zip_cycle_pad, Phillip Lord, 2015/08/04
- [elpa] externals/dash d0c6fc0 371/426: Merge pull request #104 from fbergroth/linkify-docs, Phillip Lord, 2015/08/04
- [elpa] externals/dash c08fcba 299/426: Fixed documentation of `-last-item'., Phillip Lord, 2015/08/04
- [elpa] externals/dash f96196a 289/426: Merge pull request #75 from Fuco1/prefix, Phillip Lord, 2015/08/04
- [elpa] externals/dash afe2781 388/426: Merge pull request #109 from bbatsov/threading-indentation, Phillip Lord, 2015/08/04
- [elpa] externals/dash 6b64ea7 303/426: Add functions for flexibly zipping uneven lists, Phillip Lord, 2015/08/04
- [elpa] externals/dash cd137e0 310/426: `-slice` should not fill the returned list with nils if to > length,
Phillip Lord <=
- [elpa] externals/dash 5219ac0 422/426: [-let] Eliminate useless re-binding of symbols when sources are immutable, Phillip Lord, 2015/08/04
- [elpa] externals/dash a06e66e 382/426: Add test for clean byte compilation, Phillip Lord, 2015/08/04
- [elpa] externals/dash 43dcd37 295/426: Only eval NUM in --dotimes once, Phillip Lord, 2015/08/04
- [elpa] externals/dash 4ecfea6 296/426: Merge pull request #79 from Fuco1/debug-forms, Phillip Lord, 2015/08/04
- [elpa] externals/dash 624c501 306/426: Add `-table` and `-table-flat`, Phillip Lord, 2015/08/04
- [elpa] externals/dash cf7ca23 415/426: [Fix #97] Add -remove-item, Phillip Lord, 2015/08/04
- [elpa] externals/dash 2eefbec 386/426: Don't use an inline comment on a line of its own, Phillip Lord, 2015/08/04
- [elpa] externals/dash bbc1d9c 309/426: `--each-while` should also expose `it-index`, Phillip Lord, 2015/08/04
- [elpa] externals/dash 6bdcfa5 286/426: Add -split-on, -split-when, Phillip Lord, 2015/08/04
- [elpa] externals/dash bd85b7c 302/426: Make -zip support infinite (circular) lists, Phillip Lord, 2015/08/04