emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] ebdb-bits 2ed54dc: Tweaks for package format correctness


From: Eric Abrahamsen
Subject: [elpa] ebdb-bits 2ed54dc: Tweaks for package format correctness
Date: Sun, 13 Aug 2017 14:20:03 -0400 (EDT)

branch: ebdb-bits
commit 2ed54dcb04d6ff25b5af9725fbe2dbcd07784ad8
Author: Eric Abrahamsen <address@hidden>
Commit: Eric Abrahamsen <address@hidden>

    Tweaks for package format correctness
---
 packages/company-ebdb/company-ebdb.el |  7 +++++++
 packages/counsel-ebdb/counsel-ebdb.el |  4 +++-
 packages/ebdb-gnorb/ebdb-gnorb.el     | 20 ++++++++------------
 packages/helm-ebdb/helm-ebdb.el       |  3 ++-
 4 files changed, 20 insertions(+), 14 deletions(-)

diff --git a/packages/company-ebdb/company-ebdb.el 
b/packages/company-ebdb/company-ebdb.el
index c7791c5..d4f673b 100644
--- a/packages/company-ebdb/company-ebdb.el
+++ b/packages/company-ebdb/company-ebdb.el
@@ -22,6 +22,13 @@
 ;; You should have received a copy of the GNU General Public License
 ;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
 
+;;; Commentary:
+
+;; Company integration for EBDB.  Copied more or less intact from
+;; company-bbdb, originally by Jan Tatarik.
+
+;;; Code:
+
 (require 'company)
 (require 'cl-lib)
 
diff --git a/packages/counsel-ebdb/counsel-ebdb.el 
b/packages/counsel-ebdb/counsel-ebdb.el
index 38e39e5..e4c38be 100644
--- a/packages/counsel-ebdb/counsel-ebdb.el
+++ b/packages/counsel-ebdb/counsel-ebdb.el
@@ -3,6 +3,7 @@
 ;; Copyright (C) 2017  Free Software Foundation, Inc.
 
 ;; Author: Eric Abrahamsen <address@hidden>
+;; Maintainer: Eric Abrahamsen <address@hidden>
 ;; Version: 1
 ;; Package-Requires: ((ivy "0.8.0") (ebdb "0.2"))
 
@@ -21,13 +22,14 @@
 
 ;;; Commentary:
 
-;; Counsel (actually ivy) integration for EBDB.
+;; Counselivy/ integration for EBDB.
 
 ;;; Code:
 
 (require 'ebdb)
 (require 'ivy)
 
+;;;###autoload
 (defun counsel-ebdb ()
   "Select EBDB contacts using the ivy/counsel interface."
   (interactive)
diff --git a/packages/ebdb-gnorb/ebdb-gnorb.el 
b/packages/ebdb-gnorb/ebdb-gnorb.el
index 91f57ed..fc4d4e5 100644
--- a/packages/ebdb-gnorb/ebdb-gnorb.el
+++ b/packages/ebdb-gnorb/ebdb-gnorb.el
@@ -3,6 +3,7 @@
 ;; Copyright (C) 2016-2017  Free Software Foundation, Inc.
 
 ;; Author: Eric Abrahamsen <address@hidden>
+;; Maintainer: Eric Abrahamsen <address@hidden>
 ;; Version: 1
 ;; Package-Requires: ((gnorb "1.1.0") (ebdb "0.2"))
 
@@ -31,16 +32,10 @@
 (require 'gnorb-org)
 (require 'gnorb-gnus)
 
-;; Probably we shouldn't use this, EBDB should not have a dependency
-;; on Org.
-
-;; Actually the real problem is that this is Gnus specific, we should
-;; have equivalent methods for all the MUAs, something like
-;; `ebdb-mua-find-messages'.
 (autoload 'org-gnus-follow-link "org-gnus")
 (autoload 'article-lapsed-string "gnus-art")
 
-(defgroup gnorb-ebdb nil
+(defgroup ebdb-gnorb nil
   "Customizations for Gnorb-specific functionality."
   :group 'ebdb)
 
@@ -48,7 +43,7 @@
   "For records with a `ebdb-gnorb-messages-field',
 collect links to a maximum of this many messages."
 
-  :group 'gnorb-ebdb
+  :group 'ebdb-gnorb
   :type 'integer)
 
 (defcustom gnorb-ebdb-define-recent 'seen
@@ -63,7 +58,7 @@ record's messages field is already full of recently-received
 messages, opening a five-year-old message (for instance) from
 this record will not push a link to the message into the field."
 
-  :group 'gnorb-ebdb
+  :group 'ebdb-gnorb
   :type '(choice (const :tag "Most recently seen" 'seen)
                  (const :tag "Most recently received" 'received)))
 
@@ -76,7 +71,7 @@ to t; if it is nil, this option will be ignored.
 This also affects how links are followed: when t, following a
 link will display the whole thread."
 
-  :group 'gnorb-ebdb
+  :group 'ebdb-gnorb
   :type 'boolean)
 
 (defcustom gnorb-ebdb-message-format "%:lapsed days: %:subject"
@@ -91,13 +86,13 @@ mentioned in the docstring of `format-time-string', which 
see, or
 the escape %:lapsed, which inserts the number of days ago the
 message was received."
 
-  :group 'gnorb-ebdb
+  :group 'ebdb-gnorb
   :type 'string)
 
 (defface gnorb-ebdb-link '((t :inherit org-link))
   "Custom face for displaying message links in the *BBDB* buffer.
   Defaults to org-link."
-  :group 'gnorb-ebdb)
+  :group 'ebdb-gnorb)
 
 (cl-defstruct gnorb-ebdb-link
   subject date group id)
@@ -236,3 +231,4 @@ to a message into the record's `gnorb-ebdb-messages-field'."
  "Gnorb field holding links to Gnus messages.")
 
 (provide 'ebdb-gnorb)
+;;; ebdb-gnorb.el ends here
diff --git a/packages/helm-ebdb/helm-ebdb.el b/packages/helm-ebdb/helm-ebdb.el
index 53f4199..63fda85 100644
--- a/packages/helm-ebdb/helm-ebdb.el
+++ b/packages/helm-ebdb/helm-ebdb.el
@@ -3,6 +3,7 @@
 ;; Copyright (C) 2017  Free Software Foundation, Inc.
 
 ;; Author: Eric Abrahamsen <address@hidden>
+;; Maintainer: Eric Abrahamsen <address@hidden>
 ;; Keywords: mail, convenience
 ;; Version: 1
 ;; Package-Requires: ((helm "1.0") (ebdb "0.2"))
@@ -22,7 +23,7 @@
 
 ;;; Commentary:
 
-;; Helm integration for EBDB.
+;; Helm integration for EBDB.  Provides the command `helm-ebdb'.
 
 ;;; Code:
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]