[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] Re: Small fix for Gnus integration

From: Carsten Dominik
Subject: Re: [Orgmode] Re: Small fix for Gnus integration
Date: Tue, 7 Jul 2009 13:27:51 +0200

I just applied the patch in the version I got from Tassilo.


- Carsten

On Jul 7, 2009, at 12:34 PM, Andreas Rottmann wrote:

Tassilo Horn <address@hidden> writes:

Andreas Rottmann <address@hidden> writes:

Hi Andreas,

Without the following patch, storing links to Gnus Article buffers
fails on CVS Emacs, as they (at least in my setup -- IMAP) always
contain a "From " line, which can't be parsed as an RFC822 header.

Could you elaborate a bit, i.e. provide such an example mail?

This is your mail as shown by Gnus after toggling the headers:


diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index 41b1be7..4cc5adb 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -128,6 +128,8 @@ If `org-store-link' was called with a prefix arg the meaning of
           (header (with-current-buffer gnus-article-buffer
                     (gnus-summary-toggle-header 1)
                     (goto-char (point-min))
+                     (when (looking-at "From ")
+                       (next-line))
           (from (mail-header 'from header))
           (message-id (org-remove-angle-brackets

Looking at the patch, I get the impression, that it's a solution to a
problem you created on your own. ;-)

If the first line of a mail starts with "From ", I'd say it's broken.

"From " lines are for example used in the mbox format[0], so I wasn't
too surprised to find it in my IMAP mails as well. However, you very
well might be right that this is a bug in the MDA (which stores the
mails, including the disputed first line, in a Maildir folder, which is
then served by via IMAP).

[0] http://www.qmail.org/man/man5/mbox.html

,----[ http://cr.yp.to/immhf/field.html ]
| The first line of a field begins with a name and a colon. The name is a
| string of one or more graphical ASCII characters other than colons,
| i.e., bytes between 33 and 126 inclusive other than 58.

The space has the ASCII code 32, so IMO it's not allowed as header field

I'm aware of that; but I never said that the "From " line is supposed to
be a header field -- it preceeds the email headers.

Regards, Rotty
Andreas Rottmann -- <http://rotty.yi.org/>

Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]