[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] [PATCH] Use save-excursion in org-map-dblocks

From: Carsten Dominik
Subject: Re: [Orgmode] [PATCH] Use save-excursion in org-map-dblocks
Date: Wed, 24 Mar 2010 12:16:20 +0100

Hi Magnus,

this looks like an OK patch and I don't have any problems applying it.
However, I do not quite understand the need for it. Can you please try to explain a bit better? Do you have two processes running over the same file
at the same time, or why is there a conflict?

Thanks for your time.

- Carsten

On Mar 23, 2010, at 6:37 PM, Magnus Henoch wrote:

This patch has been sitting in my tree for a while...  It's a fix to
org-map-dblocks, to make it use save-excursion instead of remembering
position values.  I need this since I have a dblock function that
asynchronously updates dblocks from HTTP responses, and some dblocks
ended up getting updated twice or thrice.

From 8fa75fb5174f93cc6990b605901891c2191c64f0 Mon Sep 17 00:00:00 2001
From: Magnus Henoch <address@hidden>
Date: Wed, 21 Oct 2009 12:37:32 +0100
Subject: [PATCH] * org.el (org-map-dblocks): Use save-excursion.

lisp/org.el |   13 ++++++-------
1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 7b2e95b..249aad4 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9306,16 +9306,15 @@ the property list including an extra property :name with the block name."
(defun org-map-dblocks (&optional command)
  "Apply COMMAND to all dynamic blocks in the current buffer.
If COMMAND is not given, use `org-update-dblock'."
-  (let ((cmd (or command 'org-update-dblock))
-       pos)
+  (let ((cmd (or command 'org-update-dblock)))
      (goto-char (point-min))
      (while (re-search-forward org-dblock-start-re nil t)
-       (goto-char (setq pos (match-beginning 0)))
-       (condition-case nil
-           (funcall cmd)
-         (error (message "Error during update of dynamic block")))
-       (goto-char pos)
+       (goto-char (match-beginning 0))
+        (save-excursion
+          (condition-case nil
+              (funcall cmd)
+ (error (message "Error during update of dynamic block"))))
        (unless (re-search-forward org-dblock-end-re nil t)
          (error "Dynamic block not terminated"))))))


Magnus Henoch
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.

- Carsten

reply via email to

[Prev in Thread] Current Thread [Next in Thread]