emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Orgmode] [PATCH] org-depend only blocks null->TODO state change


From: Paul Sexton
Subject: [Orgmode] [PATCH] org-depend only blocks null->TODO state change
Date: Tue, 27 Jul 2010 01:52:54 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

In agenda view, tasks which are supposed to be blocked using org-depend's
:BLOCKER: property, are not actually blocked and do not show up dimmed.

This is because of a logic error in 'org-depend-block-undo', hopefully 
fixed below.

index eb38aa0..84fa1a7 100644
--- a/d:/paul/dotemacs/site-lisp/org/contrib/lisp/org-depend.el
+++ b/d:/paul/dotemacs/site-lisp/org/contrib/lisp/org-depend-new.el
@@ -224,12 +224,13 @@ this ID property, that entry is also checked."
         blocker blockers bl p1
         (proceed-p
          (catch 'return
-           (unless (eq type 'todo-state-change)
-             ;; We are not handling this kind of change
-             (throw 'return t))
-           (unless (and (not from) (member to org-not-done-keywords))
-             ;; This is not a change from nothing to TODO, ignore it
-             (throw 'return t))
+            ;; If this is not a todo state change, or if this entry is 
+            ;; DONE, do not block
+            (when (or (not (eq type 'todo-state-change))
+                      (member from (cons 'done org-done-keywords))
+                      (member to (cons 'todo org-not-done-keywords))
+                      (not to))
+              (throw 'return t))

            ;; OK, the plan is to switch from nothing to TODO
            ;; Lets see if we will allow it.  Find the BLOCKER property





reply via email to

[Prev in Thread] Current Thread [Next in Thread]