[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Orgmode] Re: [PATCH] Alphabetical ordered lists
From: |
Nicolas Goaziou |
Subject: |
Re: [Orgmode] Re: [PATCH] Alphabetical ordered lists |
Date: |
Mon, 22 Nov 2010 19:37:41 +0100 |
User-agent: |
Wanderlust/2.15.9 (Almost Unreal) Emacs/23.2 Mule/6.0 (HANACHIRUSATO) |
Hello,
>>>>> Nathaniel Flath writes:
> although I'm not an expert in the exporting. Let me know if there's
> anything else, or if I screwed up anything when trying to figure out
> how to make a git patch(looks like it worked, though.)
I looked at your patch and here is what I've noticed so far:
- There's a bug in `org-cycle-list-bullet' where
org-list-can-be-alphabetical is called with argument missing.
- In `org-cycle-list-bullet', variable `top' stores list top point,
make use of it instead of recomputing it.
- There's a typo in `org-list-parse-list' (ogr-looking-at-p instead of
org-looking-at-p)
- Some parts of the patch are only white-space changes (for example a
change in `org-list-automatic-rules' but there are others). You
shouldn't include them, as it is not the purpose of the patch.
It doesn't help understanding your patch either.
- Why did you remove all code comments about lists in org-docbook.el?
- This is not a bug but are you sure you want to make
org-item-beginning-re a function? I understand that it permits an
user changing the value of `org-alphabetical-lists' to avoid
reloading Org, but it looks like syntax overweight to me.
I mean, anyone wanting to look for a list item will have to remember
that it must do a re-search on a function and not a string.
Hoping that helps,
Regards,
-- Nicolas