[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Typo in 'org-without-partial-completion'
From: |
Bastien |
Subject: |
Re: [O] Typo in 'org-without-partial-completion' |
Date: |
Tue, 28 Jun 2011 18:48:24 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Hi Paul,
Paul Sexton <address@hidden> writes:
> I think there's an error in 'org-without-partial-completion' in org-macs.el.
> The variable pc-mode gets bound to the value of partial-completion-mode - but
> this is a VARIABLE (t if that mode is enabled). Funcalling the value of
> the variable produces an error, unsurprisingly. This breaks insertion of
> properties with 'org-set-property'.
>
> Fixing it involves quoting the the symbol as shown below:
>
>
> (defmacro org-without-partial-completion (&rest body)
> `(let ((pc-mode (and (boundp 'partial-completion-mode)
> 'partial-completion-mode))) ; <-- quote added
> (unwind-protect
> (progn
> (when pc-mode (funcall pc-mode -1))
> ,@body)
> (when pc-mode (funcall pc-mode 1)))))
You're right -- thanks for spotting this, and for the clear analysis.
I've committed a patch.
--
Bastien