[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] patch makefile solve a couple debian build problems and a slackw

From: Achim Gratz
Subject: Re: [O] patch makefile solve a couple debian build problems and a slackware build problem
Date: Sun, 10 Jul 2011 12:07:32 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Bastien <address@hidden> writes:
> Achim and Nick, can I safely apply your patch or was it still a beta
> version?

My patch obsolotes what Nick was trying to achieve, but I'm just looking
at some other stuff in the Makefile that looks like it needs a makeover,
so I'd suggest we discuss this first and I'll submit a proper patch that
goes into patchwork. Here it goes:

It looks like the two targets relase and fixrelease have not actually
been used and at least fixrelease would not do what the comment is
trying to imply it should be doing.  If nobody uses them, these two
targets should probably be removed.

Then there's all the stuff that "makes sense only on the orgmode server,
do not run on your computer": if so, would it not be preferrable to fail
these targets when not run on the orgmode server, either by checking an
environment variable or a file that only exists on the server?

Is there any reason why the phony targets are not declared to be phony?
Even if GNU make is not used that should be compatible.

+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]