[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] Bug: Refile sometimes loses the last line [7.7 (release_7.7.15.g
Re: [O] Bug: Refile sometimes loses the last line [7.7 (release_7.7.15.gc363)]
Thu, 04 Aug 2011 17:46:39 +0200
Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.2 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
At Thu, 04 Aug 2011 09:35:24 -0500,
Jason Dunsmore wrote:
> Hi David,
> > I just pushed a simplified version of the solution: No need to count
> > lines, just check if point is at end of buffer.
> I just tried out your patch. The logic in your patch is slightly
> different - it checks if the point is at the end of the last line in the
> buffer, whereas mine checks if the point is anywhere on the last line.
> I don't think it fixes the problem. Bernt, can you test it?
I does it for me and should do the trick. I tracked down the problem
to `org-copy-subtree' not beeing able to correctly determine the end
of the subtree to copy.
The problem is here:
| (setq beg (point))
| (skip-chars-forward " \t\r\n")
| (save-excursion (outline-end-of-heading)
| (setq folded (outline-invisible-p)))
| (condition-case nil
| (org-forward-same-level (1- n) t)
| (error nil))
| (org-end-of-subtree t t))
(org-end-of-subtree t t) moves point to either 1/ the beginning of the
following sibling, 2/ the beginning of the last empty line in buffer
if it is present, or 3/ to the end of the last line if an last empty
line is missing.
3/ is the edge-case in question. 1/ and 2/ work with the assumption
that point is /not/ inside the entry if back-over-empty-lines is
for 1/ and 2/ means: Stay where you are. For 3/ it doesn't. For 3/ it
moves point to the beginning of the last line in buffer, i.e. in front
of the last line of content in the entry.
Description: PGP signature