emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH][babel] add a string input to ob-octave


From: Nicolas Goaziou
Subject: Re: [O] [PATCH][babel] add a string input to ob-octave
Date: Sat, 01 Oct 2011 09:10:30 +0200

Hello,

Litvinov Sergey <address@hidden> writes:

> +    (cond
> +     ((stringp var)
> +      (format "\'%s\'" (or var "nil")))
> +     (t
> +      (format "%s" (or var "nil"))))))

Just nitpicking:

In the first case, var is already identified as a string, so it will
always be non-nil, and your "or" is useless.

In the second case, (or var "nil") is redundant, as (format "%s" nil)
already returns "nil".

In other words, replacing (or var "nil") with var would be enough in
both cases.

Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]