[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] - Fix org-fast-tag-selection

From: Bastien
Subject: Re: [O] [PATCH] - Fix org-fast-tag-selection
Date: Tue, 03 Apr 2012 16:29:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)

Noorul Islam Kamal Malmiyoda <address@hidden> writes:

> Not necessary this time.

Okay, thanks.

I amended http://orgmode.org/worg/org-contribute.html to explain why
patches made with `git format-patch' are always preferred, even small

I'm less and less using Patchwork as a way to apply patches, because I
find commit messages to be sometimes messy that way.

Instead, I have local folders with patches I want to apply/review/etc.
I patch Org using `git apply' when I want to test, `git am' when I want
to commit a properly formatted patch.

It means that for each patch that doesn't have a ChangeLog, I have to 
(1) add it myself and (2) manually use git commit --author="<author>"
to have the correct author displayed.

To summarize, whether the patch is *small or big* is not the right
criterium to decide whether a simple `git diff' is acceptable -- it's
more about whether the patch is sent for testing purpose first, or
whether it is considered applicable as such.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]