Re: [O] [PATCH] Allow relative times in clocktable tstart and tend options

[Ivan Vilata i Balaguer]

Ivan Vilata i Balaguer (2012-11-28 17:11:46 +0100) wrote:

> Nicolas Goaziou (2012-11-28 13:47:32 +0100) wrote:
>
>> Ivan Vilata i Balaguer <address@hidden> writes:
>>
>>> * lisp/org-clock.el (org-clock-get-table-data): Pass tstart and tend
>>> time strings through `org-matcher-time` to allow relative times besides
>>> absolute ones, convert result to encoded time.
>>> * doc/org.texi (The clock table): Document acceptance of relative times
>>> in tstart and tend, link to syntax description.
>>>
>>> Inspired in the original relative times proposal by Ilya Shlyakhter,
>>> this is less invasive and it doesn't modify core functions, thus it
>>> avoids the original's infinite recursion when hitting normal dates in
>>> other locations.
>>>
>>> TINYCHANGE
>>
>> Thank you for your patch.
>>
>> Would you mind providing a (couple) of simple test case(s) (or
>> better, a complete ert test) for that situation?
>
> Of course, I will do it ASAP.  Thanks for considering the patch!

I expected to find some existing clocktable test I could base mine upon,
but it seems that there's none yet, and my elisp skills are insufficient
to write a completely new test mysef.  So I wrote a simple example file
(attached) in case it can be useful for a test.

Then I realised that using it for a test can be difficult since relative
times depend on the moment that functions are invoked, so no luck. :(

I'm really sorry that I can provide nothing more than this.  However it
seems to work from my live tests, and I confined the changes as much as
possible to avoid other failures.

I'm also attaching a small update to patch that adds a trivial example
to the info file.

Thanks anyway!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

clocktable-reltime.org
Description: Text document

0001-Allow-relative-times-in-clocktable-tstart-and-tend-o.patch
Description: Text Data