Re: [O] bug#12905: 24.2.50; org: edit source block causes data loss

[Nick Dokos]

Bernt Hansen <address@hidden> wrote:

> Bernt Hansen <address@hidden> writes:
> 
> > Bastien <address@hidden> writes:
> >
> >> Hi Bernt,
> >>
> >> Bernt Hansen <address@hidden> writes:
> >>
> >>> I'm not sure if this is related or not - I don't have time to track down
> >>> the offending commit right now.
> >>
> >> There is nothing new regarding editing source code in master, 
> >> except Eric's last few patches.
> >>
> >>> org-edit-special (C-c ') is currently broken in master.
> >>>
> >>> I get the following backtrace
> >>
> >> Mhh.. I can't reproduce this.
> >>
> >>> Org-mode version 7.9.2 (release_7.9.2-664-gb1f369 @
> >>> /home/bernt/git/org-mode/lisp/)
> >>
> >> I'm on release_7.9.2-692-g627d57
> >>                      ^^^
> >>
> >> Are you sure you are using master HEAD?
> >
> > I think so.  I just updated and have the same behaviour
> >
> > Org-mode version 7.9.2 (release_7.9.2-693-g8c04fb @
> > /home/bernt/git/org-mode/lisp/)
> >
> > I'll try and locate the problem commit.
> 
> git bisect identifies the following commit:
> 
> 206257aa7eb83a0a62f297e7cf0e3a7c32ff6f05 is the first bad commit
> commit 206257aa7eb83a0a62f297e7cf0e3a7c32ff6f05
> Author: Le Wang <address@hidden>
> Date:   Sun Nov 18 13:39:51 2012 +0800
> 
>     org-src: Fix org-edit-src-code for empty blocks and block with just an 
> empty line
>     
>     * lisp/org-src.el (org-edit-src-code): Use marker with insertion type
>     t to track end and remove hack requiring delete from beg to (1- end).
> 
> :040000 040000 91825ba365592800804e652e3ad66db0f8302772 
> 25f089bf9456b306afd2a0e538bcbfefc4a124f0 M    lisp
> 
> I'm just trying to edit a lisp source block
> 
> * test
> [2012-12-09 Sun 20:53]
> 
> #+begin_src lisp
> (defun bh/show-org-agenda ()
>   (interactive)
>   (switch-to-buffer "*Org Agenda*")
>   (delete-other-windows))
> 
> ; Use the current window for C-c ' source editing
> (setq org-src-window-setup 'current-window)
> 
> #+end_src
> 
> using C-c ' inside the block.
> 
> Reverting this commit fixes it for me.
> 

FWIW, I cannot reproduce this and I do have the commit you fingered in my
tree. Could it be the emacs version that makes a difference here?

Mine is

GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.4) of 
2012-09-21

Nick