emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [patch] [babel] Patches to fix tangling and variable transfer of


From: Nicolas Goaziou
Subject: Re: [O] [patch] [babel] Patches to fix tangling and variable transfer of tables in R
Date: Mon, 30 Jun 2014 14:36:54 +0200

Hello,

Rainer M Krug <address@hidden> writes:

> Attached please find two patches ready for application to fix that table
> variables were not usable adter tangling as temporary files were used.
> These patches were discussed in the thread "[babel][PATCHES] ob-R
> patches for review"

I have not much to say about the feature, since I don't use R. Usual
nitpicking follows.

> +    (if (integerp value) (format "%s <- %s" name (concat (number-to-string 
> value) "L"))
> +      (if (floatp value) (format "%s <- %s" name value)
> +     (if (stringp value) (format "%s <- %S" name value) 
> +       (format "%s <- %S" name (prin1-to-string value)))))))

I think a `cond' would be more readable here.


Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]