emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] ox-html.el: add exporting of priority


From: Nicolas Goaziou
Subject: Re: [O] [PATCH] ox-html.el: add exporting of priority
Date: Fri, 09 Jan 2015 09:20:49 +0100

Hello,

"Zane D. Purvis" <address@hidden> writes:

Thanks for the patch.

The summary line should be capitalized, i.e.,

  ox-html: Add exporting of priority

> * list/ox-html.el (org-html--priority): new function

Capitalize, too.

> (org-html-format-headline-default-function): call `org-html--priority'

Ditto.

> (org-html-style-default): add `.priority'

Ditto.

> +(defun org-html--priority (priority info)
> +  "Format a priority into HTML.
> +PRIORITY is the character code of the priority or nil.
> +INFO is a plist containing export options."
> +  (when priority
> +    (format "<span class=\"priority\">[%s]</span>"
> +        (byte-to-string priority))))

Shorter:

  (and priority (format "<span class=\"priority\">[%c]</span>" priority))

Could you fix these issues before I apply your patch?


Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]